Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #121224: Register UnauthenticatedHTTP2DOSMitigation into kube #121228

Merged
merged 1 commit into from Oct 14, 2023
Merged

Automated cherry pick of #121224: Register UnauthenticatedHTTP2DOSMitigation into kube #121228

merged 1 commit into from Oct 14, 2023

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Oct 13, 2023 •
edited

Cherry pick of #121224 on release-1.25.

#121224: Register UnauthenticatedHTTP2DOSMitigation into kube

For details on the cherry pick process, see the cherry pick requests page.

the release note in the previous PR that added the gate is sufficient - this PR makes the gate work consistently

NONE

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Oct 13, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 13, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2023
@liggitt liggitt changed the title Automated cherry pick of #121226: Register UnauthenticatedHTTP2DOSMitigation into kube Automated cherry pick of #121224: Register UnauthenticatedHTTP2DOSMitigation into kube Oct 13, 2023
@liggitt
Copy link
Member Author

liggitt commented Oct 13, 2023

/kind cleanup
/sig api-machinery
/cc @kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team October 13, 2023 22:00
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 13, 2023
@liggitt
Copy link
Member Author

liggitt commented Oct 13, 2023

/kind cleanup
/sig api-machinery
/cc @kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 13, 2023
@dims
Copy link
Member

dims commented Oct 13, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cf211202a4966bd039b5706db93ac8bae8d2d8b3

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jeremyrickard jeremyrickard added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 14, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit e6b0f77 into kubernetes:release-1.25 Oct 14, 2023
15 checks passed
@Jefftree
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 16, 2023
@m-chau m-chau mentioned this pull request Oct 24, 2023
Merged
@liggitt liggitt deleted the automated-cherry-pick-of-#121226-upstream-release-1.25 branch October 26, 2023 21:25
@enj enj mentioned this pull request Nov 16, 2023
Closed
@m-chau m-chau mentioned this pull request Nov 17, 2023
Merged
m-chau pushed a commit to m-chau/kubernetes-tmp that referenced this pull request Nov 17, 2023
@haitch
Merge pull request kubernetes#6 from m-chau/automated-cherry-pick-of-…
fda8c88 
…#121201-kubernetes#121228-upstream-release-1.24

Automated cherry pick of kubernetes#121201 kubernetes#121228 upstream release 1.24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@liggitt @dims @k8s-ci-robot @Jefftree @jeremyrickard