Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register UnauthenticatedHTTP2DOSMitigation into kube components #121224

Merged
merged 1 commit into from
Oct 14, 2023

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Oct 13, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Ensures the UnauthenticatedHTTP2DOSMitigation gate is register for all kube components, so deployments that manage feature gates homogenously across all components can use it.

Does this PR introduce a user-facing change?

NONE

/cc @enj @dims @jeremyrickard

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 13, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 13, 2023
@dims
Copy link
Member

dims commented Oct 13, 2023

/sig architecture

previous PR(s) - https://github.com/kubernetes/kubernetes/pulls?q=is%3Apr+UnauthenticatedHTTP2DOSMitigation

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 13, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5d23436445ccf8947b16056c7b3752c55b2fd82d

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d18a97c into kubernetes:master Oct 14, 2023
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 14, 2023
k8s-ci-robot added a commit that referenced this pull request Oct 14, 2023
…226-upstream-release-1.25

Automated cherry pick of #121224: Register UnauthenticatedHTTP2DOSMitigation into kube
k8s-ci-robot added a commit that referenced this pull request Oct 14, 2023
…224-upstream-release-1.28

Automated cherry pick of #121224: Register UnauthenticatedHTTP2DOSMitigation into kube
k8s-ci-robot added a commit that referenced this pull request Oct 16, 2023
…226-upstream-release-1.26

Automated cherry pick of #121224: Register UnauthenticatedHTTP2DOSMitigation into kube
k8s-ci-robot added a commit that referenced this pull request Oct 16, 2023
…225-upstream-release-1.27

Automated cherry pick of #121224: Register UnauthenticatedHTTP2DOSMitigation into kube
timuthy added a commit to timuthy/gardener that referenced this pull request Oct 18, 2023
The feature gate was added retrospectively to versions `1.25`, `1.26`, `1.27`
and `1.28`, see kubernetes/kubernetes#121224.
gardener-prow bot pushed a commit to gardener/gardener that referenced this pull request Oct 19, 2023
The feature gate was added retrospectively to versions `1.25`, `1.26`, `1.27`
and `1.28`, see kubernetes/kubernetes#121224.
gardener-ci-robot pushed a commit to gardener-ci-robot/gardener that referenced this pull request Oct 19, 2023
The feature gate was added retrospectively to versions `1.25`, `1.26`, `1.27`
and `1.28`, see kubernetes/kubernetes#121224.
gardener-ci-robot pushed a commit to gardener-ci-robot/gardener that referenced this pull request Oct 19, 2023
The feature gate was added retrospectively to versions `1.25`, `1.26`, `1.27`
and `1.28`, see kubernetes/kubernetes#121224.
gardener-ci-robot pushed a commit to gardener-ci-robot/gardener that referenced this pull request Oct 19, 2023
The feature gate was added retrospectively to versions `1.25`, `1.26`, `1.27`
and `1.28`, see kubernetes/kubernetes#121224.
gardener-prow bot pushed a commit to gardener/gardener that referenced this pull request Oct 19, 2023
The feature gate was added retrospectively to versions `1.25`, `1.26`, `1.27`
and `1.28`, see kubernetes/kubernetes#121224.

Co-authored-by: Tim Usner <tim.usner@sap.com>
gardener-prow bot pushed a commit to gardener/gardener that referenced this pull request Oct 19, 2023
The feature gate was added retrospectively to versions `1.25`, `1.26`, `1.27`
and `1.28`, see kubernetes/kubernetes#121224.

Co-authored-by: Tim Usner <tim.usner@sap.com>
gardener-prow bot pushed a commit to gardener/gardener that referenced this pull request Oct 19, 2023
The feature gate was added retrospectively to versions `1.25`, `1.26`, `1.27`
and `1.28`, see kubernetes/kubernetes#121224.

Co-authored-by: Tim Usner <tim.usner@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants