Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcd: Update to version 3.5.11 #122393

Merged
merged 1 commit into from Dec 21, 2023
Merged

etcd: Update to version 3.5.11 #122393

merged 1 commit into from Dec 21, 2023

Conversation

mzaian
Copy link
Contributor

@mzaian mzaian commented Dec 19, 2023 •
edited

What type of PR is this?

/kind bug

What this PR does / why we need it:

Update etcd to version 3.5.11 See release: v3.5.11.

Which issue(s) this PR fixes:
Fixes NONE #

Does this PR introduce a user-facing change?:
NONE

etcd: Update to v3.5.11

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 19, 2023
@mzaian mzaian mentioned this pull request Dec 19, 2023
Merged
@k8s-ci-robot k8s-ci-robot added area/kubeadm area/provider/gcp Issues or PRs related to gcp provider area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 19, 2023
@mzaian
Copy link
Contributor Author

mzaian commented Dec 19, 2023

/sig etcd

@k8s-ci-robot k8s-ci-robot added the sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. label Dec 19, 2023
@k8s-ci-robot k8s-ci-robot added the area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework label Dec 19, 2023
@mzaian mzaian changed the title WIP: etcd: Update to version 3.5.11 etcd: Update to version 3.5.11 Dec 19, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 19, 2023
@mzaian
Copy link
Contributor Author

mzaian commented Dec 19, 2023

/retest

neolit123
neolit123 reviewed Dec 19, 2023
View reviewed changes
cmd/kubeadm/app/constants/constants.go
26: "3.5.11-0",
27: "3.5.11-0",
28: "3.5.11-0",
29: "3.5.11-0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @SataQiu
maybe we can handle the upgrade in this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link #122265

@seans3
Copy link
Contributor

seans3 commented Dec 19, 2023

This PR looks like a duplicate of: #122328

That PR is updating 520 files, while this PR is updating 8 files.

@pacoxu
Copy link
Member

pacoxu commented Dec 20, 2023

/lgtm
/approve

This PR looks like a duplicate of: #122328

That PR is updating 520 files, while this PR is updating 8 files.

#122328 only bump the golang dependencies in go.mod/go.sum and vendor.

This PR bumps the etcd image version as a follow up of #122233 and kubernetes/k8s.io#6207.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c59e51ca35eed6c00de4403724ca38194b9bfa47

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2023
@mzaian
Copy link
Contributor Author

mzaian commented Dec 20, 2023

Rebased to get the v1.30 change from v1.30 #122265

@mzaian
Copy link
Contributor Author

mzaian commented Dec 20, 2023

/retest

@pacoxu
Copy link
Member

pacoxu commented Dec 21, 2023

/assign @dims @liggitt

SataQiu
SataQiu reviewed Dec 21, 2023
View reviewed changes
Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 04358db42064f3687f4d51f3d32e1a932b3a4bf7

@dims
Copy link
Member

dims commented Dec 21, 2023

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, mzaian, pacoxu, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0d53055 into kubernetes:master Dec 21, 2023
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Dec 21, 2023
@seans3
Copy link
Contributor

seans3 commented Dec 21, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SataQiu SataQiu SataQiu left review comments

@chendave chendave Awaiting requested review from chendave

@jpbetz jpbetz Awaiting requested review from jpbetz

@pacoxu pacoxu Awaiting requested review from pacoxu

@neolit123 neolit123 Awaiting requested review from neolit123

Assignees

@dims dims

@liggitt liggitt

@pacoxu pacoxu

@SataQiu SataQiu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubeadm area/provider/gcp Issues or PRs related to gcp provider area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@mzaian @seans3 @pacoxu @k8s-ci-robot @dims @neolit123 @SataQiu @liggitt