Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump etcd from v3.5.10 to v3.5.11 #122328

Closed
wants to merge 1 commit into from
Closed

Bump etcd from v3.5.10 to v3.5.11 #122328

wants to merge 1 commit into from

Conversation

bzsuni
Copy link
Contributor

@bzsuni bzsuni commented Dec 15, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

as the issue say: etcd-io/etcd#16960

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kube-proxy area/kubectl labels Dec 15, 2023
@k8s-ci-robot k8s-ci-robot requested review from andyzhangx and a team December 15, 2023 02:47
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 15, 2023
@pacoxu
Copy link
Member

pacoxu commented Dec 15, 2023 

2023/12/15 02:53:48 Status diff:
  []uint8(
  	"""
  	... // 153 identical lines
  	      "go.etcd.io/etcd/client/v3",
  	      "go.etcd.io/etcd/server/v3",
- 	      "go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc",
  	      "google.golang.org/api",
  	      "google.golang.org/genproto/googleapis/api",
  	... // 27 identical lines
  	"""
  )
2023/12/15 02:53:48 Good news! Unwanted module "google.golang.org/genproto" dropped the following dependants:
2023/12/15 02:53:48    go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc
2023/12/15 02:53:48 !!! Remove those from status.unwantedReferences["google.golang.org/genproto"] in /home/prow/go/src/k8s.io/kubernetes/hack/unwanted-dependencies.json to ensure they don't get reintroduced.
exit status 1
Removing /home/prow/go/src/k8s.io/kubernetes/_tmp/kube-vendor.lLXqYf
+++ exit code: 1

hack/unwanted-dependencies.json needs an update.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 20, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 22, 2023
@bzsuni
Copy link
Contributor Author

bzsuni commented Dec 25, 2023

/test pull-kubernetes-integration

@bart0sh bart0sh moved this from Triage to Needs Approver in SIG Node PR Triage Dec 25, 2023
@bart0sh bart0sh moved this from Needs Approver to Needs Reviewer in SIG Node PR Triage Dec 25, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bzsuni
Once this PR has been reviewed and has the lgtm label, please assign deads2k, liggitt for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 2, 2024
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 2, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 3, 2024
@bzsuni
Copy link
Contributor Author

bzsuni commented Jan 3, 2024

/test pull-kubernetes-dependencies

@bzsuni
Bump etcd from v3.5.10 to v3.5.11
c32385c 
Signed-off-by: bzsuni <bingzhe.sun@daocloud.io>
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Archive-it in SIG Node CI/Test Board Jan 3, 2024
@mzaian
Copy link
Contributor

mzaian commented Jan 9, 2024

/retest

@k8s-ci-robot
Copy link
Contributor

@bzsuni: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-integration c32385c link true /test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 24, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmhbnz
Copy link
Member

jmhbnz commented Feb 15, 2024

Hey @bzsuni - I'm closing this in favor of the more recent 3.5.12 pr #123056. Both are impacted by the same tracing_test.go:1003: Timed out waiting for trace issue so I wouldn't want to be investigating that in two difference places.

Additionally the 3.5.12 pr has some more active discussion on what the potential causes could be.

/close

@k8s-ci-robot
Copy link
Contributor

@jmhbnz: Closed this PR.

In response to this:

Hey @bzsuni - I'm closing this in favor of the more recent 3.5.12 pr #123056. Both are impacted by the same tracing_test.go:1003: Timed out waiting for trace issue so I wouldn't want to be investigating that in two difference places.

Additionally the 3.5.12 pr has some more active discussion on what the potential causes could be.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SIG Node CI/Test Board automation moved this from Archive-it to Done Feb 15, 2024
SIG Node PR Triage automation moved this from Needs Reviewer to Done Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

Assignees
No one assigned
Labels
area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kube-proxy area/kubectl area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
SIG CLI
Archived in project
SIG Node CI/Test Board
Done
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bzsuni @pacoxu @seans3 @k8s-ci-robot @mzaian @jmhbnz