Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StatefulSet Autodelete owner references should respect controller #122400

Closed
mattcary opened this issue Dec 19, 2023 · 3 comments · Fixed by #122499
Closed

StatefulSet Autodelete owner references should respect controller #122400

mattcary opened this issue Dec 19, 2023 · 3 comments · Fixed by #122499
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/apps Categorizes an issue or PR as relevant to SIG Apps. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@mattcary
Copy link
Contributor

What happened?

StatefulSet owner references don't set or respect the controller flag.

That should either be used, preferably through controller-runtime/controllerutil as is used in controllers like RabbitMq, crunchy postgres and Neo4jCluster.

We have observed these controllers being used on stateful sets. We haven't seen any reports of controller contention problems but the potential is there.

This should delay GA promotion of the statefulset autodelete feature (kubernetes/enhancements#1847).

/assign @mattcary
/sig apps

What did you expect to happen?

n/a

How can we reproduce it (as minimally and precisely as possible)?

n/a

Anything else we need to know?

No response

Kubernetes version

n/a

Cloud provider

OS version

# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here

# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here

Install tools

Container runtime (CRI) and version (if applicable)

Related plugins (CNI, CSI, ...) and versions (if applicable)

@mattcary mattcary added the kind/bug Categorizes issue or PR as related to a bug. label Dec 19, 2023
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 19, 2023
@mattcary
Copy link
Contributor Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 19, 2023
@mattcary
Copy link
Contributor Author

/cc @msau42

@mattcary
Copy link
Contributor Author

Hmm, I don't see controller-runtime used in k8s. What's in pkg/controller/controller_utils.go doesn't seem appropriate so I guess I'll just roll it manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/apps Categorizes an issue or PR as relevant to SIG Apps. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants