Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-1847: ownerRef controller update #4375

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

KEP-1847: ownerRef controller update #4375

wants to merge 1 commit into from

Conversation

mattcary
Copy link
Contributor

  • One-line PR description: describe the update to owner reference controller usage

/cc @msau42

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 21, 2023
@msau42
Copy link
Member

msau42 commented Dec 21, 2023

/lgtm

@mattcary
Copy link
Contributor Author

I'm getting feedback from @msau42 to double check that this is reaonable.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 21, 2023
@mattcary
Copy link
Contributor Author

Oh, that was quick :-P

@mattcary
Copy link
Contributor Author

/assign @kow3ns

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2024
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mattcary
Once this PR has been reviewed and has the lgtm label, please ask for approval from kow3ns. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 16, 2024
atiratree
atiratree reviewed Jan 18, 2024
View reviewed changes
Copy link
Member

@atiratree atiratree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two nits, otherwise lgtm

keps/sig-apps/1847-autoremove-statefulset-pvcs/README.md Outdated Show resolved Hide resolved
keps/sig-apps/1847-autoremove-statefulset-pvcs/README.md Show resolved Hide resolved
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 17, 2024
@mattcary
Copy link
Contributor Author

/remove-lifecycle stale

This is pending kubernetes/kubernetes#122499

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 18, 2024
atiratree
atiratree reviewed Jun 7, 2024
View reviewed changes
keps/sig-apps/1847-autoremove-statefulset-pvcs/kep.yaml
@@ -25,7 +25,7 @@ latest-milestone: "v1.27"
milestone:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we can update latest-milestone as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atiratree atiratree atiratree left review comments

@msau42 msau42 Awaiting requested review from msau42

Assignees

@kow3ns kow3ns

@msau42 msau42

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Apps
Status: Needs Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mattcary @msau42 @k8s-ci-robot @k8s-triage-robot @atiratree @kow3ns