Promote Filip as sig-apps approver #124414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
size/XS
k8s-ci-robot
added
sig/apps
k8s-ci-robot
added
the
approved
|
/triage accepted |
k8s-ci-robot
added
do-not-merge/hold
|
cc @atiratree |
|
Yay! |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: c093f33970e162a502e5efe235ecea64e4a82d6b
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, janetkuo, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks a lot everyone! 😁 |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/sig apps
What this PR does / why we need it:
@atiratree has been very active participant in sig-apps over the past years. His main contributions has been:
and multiple code reviews and code changes in broad controller areas.
Special notes for your reviewer:
/assign @janetkuo @kow3ns
for sig-apps approval
/assign @dims
for top-level changes
Does this PR introduce a user-facing change?