Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregator for ConfigMap resource implementation #18455

Closed
12 tasks done
pmorie opened this issue Dec 9, 2015 · 14 comments
Closed
12 tasks done

Aggregator for ConfigMap resource implementation #18455

pmorie opened this issue Dec 9, 2015 · 14 comments
Assignees
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@pmorie
Copy link
Member

pmorie commented Dec 9, 2015

This issue aggregates the PRs for the implementation of the config resource described in #6477

cc @tmrts

@tmrts
Copy link
Contributor

tmrts commented Dec 9, 2015

We'll need usage docs as well. A lot of people are anxious to try it out.

@davidopp davidopp added this to the v1.2 milestone Jan 10, 2016
@davidopp davidopp added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jan 10, 2016
@bgrant0607 bgrant0607 changed the title Aggregator for Config resource implementation Aggregator for ConfigMap resource implementation Jan 16, 2016
@therc
Copy link
Member

therc commented Jan 27, 2016

The issue numbers for "Move to main API" and "Documentation" are the same; is that intended? I wanted to point out that https://github.com/kubernetes/kubernetes/blob/master/docs/design/configmap.md still talks about [valueFrom: configMap: configMapName:], while it should be [valueFrom: configMapKeyRef: name:]. It's not clear where to report that, though.

@thockin
Copy link
Member

thockin commented Jan 28, 2016

@pmorie

On Wed, Jan 27, 2016 at 8:23 AM, Rudi C notifications@github.com wrote:

The issue numbers for "Move to main API" and "Documentation" are the same;
is that intended? I wanted to point out that
https://github.com/kubernetes/kubernetes/blob/master/docs/design/configmap.md
still talks about [valueFrom: configMap: configMapName:], while it should
be [valueFrom: configMapKeyRef: name:]. It's not clear where to report
that, though.


Reply to this email directly or view it on GitHub
#18455 (comment)
.

@pmorie
Copy link
Member Author

pmorie commented Jan 28, 2016

@therc updated, thanks for noticing that!

@therc
Copy link
Member

therc commented Jan 30, 2016

Is there any plan to allow consuming ConfigMap items as e.g. command line flags? Even in #18215 I don't see any mentions of CM (the conversation is hard to follow...). And the downward API only sets environment variables. All I want to do is set e.g. the cluster name or some other cluster-wide constant once, then have a bunch of specs reflect that ("--domain=CLUSTER.example.com"). I'm not even talking about conditionals, regular expressions, arbitrary math leading to computing Mandelbrot sets, etc.: just straight text substitutions as a starting point.

@thockin
Copy link
Member

thockin commented Feb 2, 2016

You can already do env-var expansion in commandlines, so you should be able
to define an env var from a ConfigMap, then reference that env var in your
commandline as $(NAME)

On Fri, Jan 29, 2016 at 5:07 PM, Rudi C notifications@github.com wrote:

Is there any plan to allow consuming ConfigMap items as e.g. command line
flags? Even in #18215
#18215 I don't see any
mentions of CM (the conversation is hard to follow...). And the downward
API only sets environment variables. All I want to do is set e.g. the
cluster name or some other cluster-wide constant once, then have a bunch of
specs reflect that ("--domain=CLUSTER.example.com"). I'm not even talking
about conditionals, regular expressions, arbitrary math leading to
computing Mandelbrot sets, etc.: just straight text substitutions as a
starting point.


Reply to this email directly or view it on GitHub
#18455 (comment)
.

@pmorie
Copy link
Member Author

pmorie commented Feb 4, 2016

You can already do env-var expansion in commandlines, so you should be able to define an env var from a ConfigMap, then reference that env var in your commandline as $(NAME)

bingo

@mwielgus
Copy link
Contributor

mwielgus commented Feb 7, 2016

cc: @piosz @fgrzadkowski

@davidopp
Copy link
Member

@pmorie Please be sure to explain this prominently in the documentation (a lot of people will have the same question @therc had, since that's almost certainly going to be the main way that people consume ConfigMap).

@davidopp
Copy link
Member

@pmorie All of the check boxes are checked now :) Should we close the issue?

@yvespp
Copy link
Contributor

yvespp commented Feb 26, 2016

When I do "kubectl get" I don't see configmap in the error message, shouldn't it be there?

lodur:config yves$ kubectl version
Client Version: version.Info{Major:"1", Minor:"2+", GitVersion:"v1.2.0-alpha.8", GitCommit:"5918967a86489460846af94a5c393d971337be29", GitTreeState:"clean"}
Server Version: version.Info{Major:"1", Minor:"2+", GitVersion:"v1.2.0-alpha.8", GitCommit:"5918967a86489460846af94a5c393d971337be29", GitTreeState:"clean"}
lodur:config yves$ kubectl get 

You must specify the type of resource to get. Valid resource types include:
   * componentstatuses (aka 'cs')
   * events (aka 'ev')
   * endpoints (aka 'ep')
   * horizontalpodautoscalers (aka 'hpa')
   * ingress (aka 'ing')
   * jobs
   * limitranges (aka 'limits')
   * nodes (aka 'no')
   * namespaces (aka 'ns')
   * pods (aka 'po')
   * persistentvolumes (aka 'pv')
   * persistentvolumeclaims (aka 'pvc')
   * quota
   * resourcequotas (aka 'quota')
   * replicasets (aka 'rs')
   * replicationcontrollers (aka 'rc')
   * secrets
   * serviceaccounts
   * services (aka 'svc')
error: Required resource not specified.

@pmorie
Copy link
Member Author

pmorie commented Feb 29, 2016

@yvespp that's weird -- i'll look into it.

@davidopp if you don't mind i'd like to keep it open to track any follow-up tasks that shake out over the next day or two.

@bgrant0607
Copy link
Member

@pmorie Can this be closed? Is there an issue for docs?

@bgrant0607
Copy link
Member

I see a PR for docs. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

9 participants