Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make namespace controller delete configMaps in namespace #20645

Merged
merged 1 commit into from Feb 10, 2016
Merged

Make namespace controller delete configMaps in namespace #20645

merged 1 commit into from Feb 10, 2016

Conversation

pmorie
Copy link
Member

@pmorie pmorie commented Feb 4, 2016

@k8s-github-robot
Copy link

Labelling this PR as size/S

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 4, 2016
@k8s-bot
Copy link

k8s-bot commented Feb 4, 2016

GCE e2e build/test failed for commit 41a1d5348562bc5c5b0cee72516d3d7ba266a4a5.

@derekwaynecarr
Copy link
Member

In this PR (#20076), I am trying to move all calls that can support it to use DeleteCollection, can you make this use that call instead?

derekwaynecarr
derekwaynecarr reviewed Feb 4, 2016
View reviewed changes
pkg/controller/namespace/namespace_controller.go
@@ -454,6 +458,20 @@ func deleteSecrets(kubeClient clientset.Interface, ns string) error {
return nil
}

func deleteConfigMaps(kubeClient clientset.Interface, ns string) error {
items, err := kubeClient.Legacy().ConfigMaps(ns).List(api.ListOptions{})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DeleteCollection()

@derekwaynecarr derekwaynecarr added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Feb 4, 2016
@pmorie pmorie force-pushed the namespace-controller-config branch from 41a1d53 to 232f94e Compare February 4, 2016 17:43
@pmorie pmorie mentioned this pull request Feb 4, 2016
Closed
12 tasks
@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 4, 2016
@k8s-bot
Copy link

k8s-bot commented Feb 4, 2016

GCE e2e build/test failed for commit 232f94e23cb2a08699437df28cd612b4bd2ec41e.

@pmorie pmorie force-pushed the namespace-controller-config branch from 232f94e to 522c2b0 Compare February 4, 2016 19:12
@k8s-bot
Copy link

k8s-bot commented Feb 4, 2016

GCE e2e build/test failed for commit 522c2b026e1fbf501d8aa371ba6234684ba0fa0b.

@pmorie
Copy link
Member Author

pmorie commented Feb 5, 2016

@k8s-bot test this issue: #20694

@k8s-bot
Copy link

k8s-bot commented Feb 5, 2016

GCE e2e build/test failed for commit 522c2b026e1fbf501d8aa371ba6234684ba0fa0b.

@pmorie pmorie force-pushed the namespace-controller-config branch from 522c2b0 to 88a1605 Compare February 9, 2016 17:52
@k8s-bot
Copy link

k8s-bot commented Feb 9, 2016

GCE e2e build/test failed for commit 88a16052d2a025bb7aad78f80bd546430116bf7f.

@pmorie
Copy link
Member Author

pmorie commented Feb 9, 2016

@k8s-bot test this issue: #20916

@k8s-bot
Copy link

k8s-bot commented Feb 10, 2016

GCE e2e test build/test passed for commit 88a16052d2a025bb7aad78f80bd546430116bf7f.

@derekwaynecarr
Copy link
Member

Can we merge #20076 first?

@pmorie
Copy link
Member Author

pmorie commented Feb 10, 2016

@derekwaynecarr my bad, I had forgotten about the dependency on your pull.

@k8s-github-robot
Copy link

PR needs rebase

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2016
@derekwaynecarr
Copy link
Member

rebase then i will lgtm

@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2016
@k8s-bot
Copy link

k8s-bot commented Feb 10, 2016

GCE e2e test build/test passed for commit 3a505ac.

@derekwaynecarr derekwaynecarr added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Feb 10, 2016

GCE e2e test build/test passed for commit 3a505ac.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Feb 10, 2016
Merge pull request #20645 from pmorie/namespace-controller-config
afc5564 
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit afc5564 into kubernetes:master Feb 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@derekwaynecarr derekwaynecarr

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@pmorie @k8s-github-robot @k8s-bot @derekwaynecarr @k8s-teamcity-mesosphere @smarterclayton @googlebot