-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kuberentes client no longer compiles due to change in docker repo #18774
Comments
After going through the history, it appears it was removed in this commit. It's been removed here. moby/moby@4352da7#diff-8a4a471eeec9e5954d06c11472eb5044L113 However, there doesn't appear to be any documentation on where equivalent functionality is provided. Aside from copying the Godeps from the kubernetes source tree with a release tag into my own repo, is there any other methodology for addressing this problem? |
Kubernetes uses Godeps to vendor in dependent code, such as |
And btw, ParseRepositoryTag was replaced with |
Hi @ncdc Thanks for the help. I've been playing around with this and not having a lot of luck. I've tried the following.
However, I receive quite a few errors when godeps does not understand the copied git repo Obviously this doesn't work, it seems I don't have the Kubernetes source from the hack build. What are the steps to developing with the Kubernetes client and go? I'm new to both Kubernetes and go, unfortunately there isn't any documentation on getting running with the go client. https://github.com/kubernetes/kubernetes/tree/release-1.1/pkg/client/ I'd be happy to contribute to the documentation once I have some instructions. I'm just not sure where I should start. |
@tnine the build setup for development is a bit finicky. The development guide is a good place to start. There's a section on godeps that should help you fix your setup. |
Has there been any activity on this? I see a number of things in the referenced issue but I'm still seeing this error with vendored code. Is there a reason that the code hasn't been updated to use the |
@jdoliner Unfortunately, our code isn't factored in such a way to be go gettable, in whole or in part. We also don't yet have a client library we support for other users. In the meantime, you could check out kubelite: If you'd like to help, I recommend checking out the API machinery SIG. |
1.2 is going to have a version-locked client available. But it will still have an overly broad import dependency tree. We will fix that over time. |
This caused a dependency chain reaction (sigh): * All the k8s packages had to be fetched again. This in turn required: * Pining github.com/docker/docker/pkg/parsers to 0f5c9d301b9b1cca66b3ea0f9dec3b5317d3686d to cirvumvent kubernetes/kubernetes#18774 * Update github.com/juju/ratelimit * Make probe/kubernetes/client.go comply with API changes.
This caused a dependency chain reaction (sigh): * All the k8s packages had to be fetched again. This in turn required: * Pining github.com/docker/docker/pkg/parsers to 0f5c9d301b9b1cca66b3ea0f9dec3b5317d3686d to cirvumvent kubernetes/kubernetes#18774 * Update github.com/juju/ratelimit * Make probe/kubernetes/client.go comply with API changes.
This caused a dependency chain reaction (sigh): * All the k8s packages had to be fetched again. This in turn required: * Pining github.com/docker/docker/pkg/parsers to 0f5c9d301b9b1cca66b3ea0f9dec3b5317d3686d to cirvumvent kubernetes/kubernetes#18774 * Update github.com/juju/ratelimit * Make probe/kubernetes/client.go comply with API changes.
This caused a dependency chain reaction (sigh): * All the k8s packages had to be fetched again. This in turn required: * Pining github.com/docker/docker/pkg/parsers to 0f5c9d301b9b1cca66b3ea0f9dec3b5317d3686d to cirvumvent kubernetes/kubernetes#18774 * Update github.com/juju/ratelimit * Make probe/kubernetes/client.go comply with API changes.
This caused a dependency chain reaction (sigh): * All the k8s packages had to be fetched again. This in turn required: * Pining github.com/docker/docker/pkg/parsers to 0f5c9d301b9b1cca66b3ea0f9dec3b5317d3686d to cirvumvent kubernetes/kubernetes#18774 * Update github.com/juju/ratelimit * Make probe/kubernetes/client.go comply with API changes.
This caused a dependency chain reaction (sigh): * All the k8s packages had to be fetched again. This in turn required: * Pining github.com/docker/docker/pkg/parsers to 0f5c9d301b9b1cca66b3ea0f9dec3b5317d3686d to cirvumvent kubernetes/kubernetes#18774 * Update github.com/juju/ratelimit * Make probe/kubernetes/client.go comply with API changes.
This caused a dependency chain reaction (sigh): * All the k8s packages had to be fetched again. This in turn required: * Pining github.com/docker/docker/pkg/parsers to 0f5c9d301b9b1cca66b3ea0f9dec3b5317d3686d to cirvumvent kubernetes/kubernetes#18774 * Update github.com/juju/ratelimit * Make probe/kubernetes/client.go comply with API changes.
To work with godeps and kube you basically need to do:
That should get both your $GOPATH and the stuff in Godep/_workspace 'the same'. and should let you do your own builds without using the hack/ scripts, as it seems you are trying to do. |
Hi all,
I'm attempting to write some kubernetes clients in go. I'm attempting to download the latest client, and it fails with the following error.
It appears the "ParseRepositoryTag" function has been removed from the latest docker client.
The text was updated successfully, but these errors were encountered: