Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All controllers should raise events when they can't create objects as expected #21912

Open
soltysh opened this issue Feb 24, 2016 · 7 comments
Open

All controllers should raise events when they can't create objects as expected #21912

soltysh opened this issue Feb 24, 2016 · 7 comments
Labels
area/controller-manager kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling.
Projects
Workloads

Comments

@soltysh
Copy link
Contributor

soltysh commented Feb 24, 2016

This is coming from #21079 (comment):

All controllers should raise events when they can't create objects as expected (Pods, ReplicaSets, whatever), except when namespace deletion is in progress.

cc @piosz @mwielgus @jszczepkowski @madhusudancs @janetkuo @Kargakis @mikedanese @erictune @bgrant0607
@soltysh soltysh mentioned this issue Feb 24, 2016
Closed
@bgrant0607 bgrant0607 added priority/backlog Higher priority than priority/awaiting-more-evidence. team/ux labels Feb 24, 2016
@bgrant0607 bgrant0607 added this to the next-candidate milestone Feb 24, 2016
This was referenced Feb 26, 2016
Closed
Closed
@mikedanese mikedanese mentioned this issue Apr 11, 2016
Closed
@bgrant0607 bgrant0607 mentioned this issue Apr 11, 2016
Closed
@bgrant0607 bgrant0607 removed this from the next-candidate milestone Apr 27, 2016
@bgrant0607 bgrant0607 mentioned this issue May 4, 2016
Merged
@bgrant0607
Copy link
Member

Frequent example: insufficient quota

@bgrant0607 bgrant0607 mentioned this issue May 4, 2016
Open
@bgrant0607 bgrant0607 mentioned this issue Jul 27, 2016
Closed
@bgrant0607 bgrant0607 mentioned this issue Aug 15, 2016
Closed
8 tasks
@bgrant0607 bgrant0607 mentioned this issue Mar 21, 2017
Closed
@k8s-github-robot k8s-github-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 31, 2017
@0xmichalis
Copy link
Contributor

/sig apps
/sig autoscaling
and more I expect

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. labels Jun 16, 2017
@0xmichalis 0xmichalis removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. team/control-plane (deprecated - do not use) labels Jun 16, 2017
@bgrant0607 bgrant0607 added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/backlog Higher priority than priority/awaiting-more-evidence. labels Sep 30, 2017
@bgrant0607
Copy link
Member

cc @kubernetes/sig-apps-feature-requests

@bgrant0607 bgrant0607 added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 30, 2017
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 6, 2018
@bgrant0607
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 23, 2018
@soltysh
Copy link
Contributor Author

soltysh commented Jan 30, 2018

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jan 30, 2018
@kow3ns kow3ns added this to Backlog in Workloads Feb 28, 2018
@bgrant0607
Copy link
Member

They should also report the reason(s) why the desired state can't be realized in the status, such as in conditions. This enables higher-level controllers, which don't/can't watch events, as well as users, to make decisions.

openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this issue Jan 31, 2019
@k8s-publishing-bot
Merge pull request kubernetes#21912 from deads2k/generate-features
e2d3e11 
UPSTREAM: <carry>: don't double pluralize features

Origin-commit: 97c83e5c6326167ab99eb6236c0f3148f7735927
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/controller-manager kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling.
Projects
SIG Apps
Status: Needs Triage
Workloads
  
Backlog
Milestone
No milestone
Development

No branches or pull requests
6 participants
@soltysh @0xmichalis @bgrant0607 @k8s-github-robot @k8s-ci-robot @fejta-bot