Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status column for kubectl get replicationcontroller/service #7483

Closed
gouyang opened this issue Apr 29, 2015 · 8 comments
Closed

Add status column for kubectl get replicationcontroller/service #7483

gouyang opened this issue Apr 29, 2015 · 8 comments
Assignees
Labels
area/kubectl priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/apps Categorizes an issue or PR as relevant to SIG Apps.
Milestone

Comments

@gouyang
Copy link
Contributor

gouyang commented Apr 29, 2015

kubectl get replicaController/service does not tell whether the replicaController is in health state or service is running, how about add a status column to indicate that?

@cjcullen cjcullen added priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Apr 29, 2015
@bgrant0607 bgrant0607 added priority/backlog Higher priority than priority/awaiting-more-evidence. area/kubectl team/ux and removed priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Oct 14, 2015
@bgrant0607 bgrant0607 added this to the v1.2-candidate milestone Jan 25, 2016
@bgrant0607
Copy link
Member

Adding this to Deployment - #20009

@bgrant0607 bgrant0607 added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. team/control-plane and removed priority/backlog Higher priority than priority/awaiting-more-evidence. labels Jan 29, 2016
@bgrant0607
Copy link
Member

Would like to add this to ReplicaSet and ReplicationController, also. Probably ReadyReplicas, which we could also add to Deployment.

@bgrant0607 bgrant0607 changed the title Add status column for kubectl get replicaController/service Add status column for kubectl get replicationcontroller/service Apr 8, 2016
@janetkuo
Copy link
Member

janetkuo commented Jun 22, 2016

@foxish let's start with adding running / ready replicas (pods) to kubectl get replicationcontroller and feel free to ask me questions

@foxish
Copy link
Contributor

foxish commented Jul 14, 2016

@janetkuo Based on our offline discussion, adding a new field to api/types.go:ReplicationControllerStatus is not preferable at the moment. So, we choose to make multiple GET calls to fetch the status of the pods. It seems difficult to see which would be the appropriate place to make those calls back to the pods.

@0xmichalis
Copy link
Contributor

@janetkuo Based on our offline discussion, adding a new field to api/types.go:ReplicationControllerStatus is not preferable at the moment. So, we choose to make multiple GET calls to fetch the status of the pods. It seems difficult to see which would be the appropriate place to make those calls back to the pods.

Can you elaborate on why? We are already doing this for Deployments and 1) I have stumbled across many cases where people want to know the available replicas of their controllers individually and 2) doing this at the replica set status and then using that at the deployment level seems more correct and would offload complexity from the deployment controller. That's why I have opened #28381

@smarterclayton
Copy link
Contributor

So I think that a serious problem with the cluster today is when pods can't be created for the following reasons:

  1. Quota
  2. Policy decisions (pod security policy)
  3. Placement constraints
  4. Any other logic that can block progress

I think 1-3 are enough to justify some small amount of status to be rolled up - it would massively improve the user experience of naive clients (kubectl describe rc foo) and web clients. It would remove a whole class of questions on stack overflow (why do I not have X things). It will become increasingly difficult over time because we will add more things to that list.

I think this may also be covered in another issue, so I don't want to hijack, but I do think from a usability issue controllers are responsible for summarizing the total state of the decisions they make, not just through events. It can definitely be tricky to keep that status up to date in a performant matter, but i think it's critical.

@bgrant0607 bgrant0607 added this to the v1.4 milestone Jul 27, 2016
@bgrant0607 bgrant0607 added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed team/control-plane labels Jul 27, 2016
@bgrant0607
Copy link
Member

bgrant0607 commented Jul 27, 2016

@Kargakis @smarterclayton I clarified with @janetkuo. Her comment was directed at @foxish rather than a general statement.

We should add an aggregate status field (probably multiple of them). I commented on #29481 as well.

As for identifying reasons such as quota, etc., that's #21912.

@smarterclayton
Copy link
Contributor

Thanks, sorry for the confusion.

k8s-github-robot pushed a commit that referenced this issue Aug 24, 2016
Automatic merge from submit-queue

kubectl: display ready replicas in 'get {rs,rc}'

Fixes #7483

@kubernetes/kubectl @janetkuo @bgrant0607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubectl priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/apps Categorizes an issue or PR as relevant to SIG Apps.
Projects
None yet
Development

No branches or pull requests

7 participants