I accidentally ran the munger locally & it touched real-github

[justinsb]

Going to link affected issues to this and add commentary as I figure out what happened.

Here are the logs:

I0227 18:13:23.754126   30214 github.go:201] Made 0 API calls since the last Reset 0.000000 calls/sec
I0227 18:13:23.756030   30214 mungegithub.go:57] Running mungers
I0227 18:15:55.482243   30214 github.go:1149] Removing comment 185264896 from Issue 20273
I0227 18:15:55.590793   30214 github.go:1128] Commenting "@kargakis\nYou must link to the test flake issue which caused you to request this manual re-test.\nRe-test requests should be in the form of: `k8s-bo
t test this issue: #<number>`\nHere is the [list of open test flakes](https://github.com/kubernetes/kubernetes/issues?q=is:issue+label:kind/flake+is:open)." in 20273
I0227 18:15:55.771203   30214 github.go:1149] Removing comment 188879479 from Issue 20273
I0227 18:15:55.924248   30214 github.go:1128] Commenting "@kargakis\nYou must link to the test flake issue which caused you to request this manual re-test.\nRe-test requests should be in the form of: `k8s-bo
t test this issue: #<number>`\nHere is the [list of open test flakes](https://github.com/kubernetes/kubernetes/issues?q=is:issue+label:kind/flake+is:open)." in 20273
I0227 18:16:07.823871   30214 github.go:1149] Removing comment 187993561 from Issue 20415
I0227 18:16:07.950095   30214 github.go:1128] Commenting "@pwittrock\nYou must link to the test flake issue which caused you to request this manual re-test.\nRe-test requests should be in the form of: `k8s-bot test this issue: #<number>`\nHere is the [list of open test flakes](https://github.com/kubernetes/kubernetes/issues?q=is:issue+label:kind/flake+is:open)." in 20415
I0227 18:16:08.103848   30214 github.go:588] Removing label "lgtm" to PR 20415
I0227 18:16:12.263085   30214 github.go:778] PR 20446 setting "Submit Queue" Github status to "Github CI tests are not green."
I0227 18:16:18.103767   30214 github.go:1128] Commenting "Travis continuous integration appears to have missed, closing and re-opening to trigger it" in 20628
I0227 18:16:18.286839   30214 github.go:992] Closing PR# 20628
I0227 18:16:23.455190   30214 github.go:1015] Opening PR# 20628
I0227 18:17:26.037538   30214 github.go:1128] Commenting "@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]" in 21499
I0227 18:17:26.243274   30214 github.go:778] PR 21499 setting "Submit Queue" Github status to "Requested and waiting for github e2e test to start running a second time."
I0227 18:18:26.596279   30214 github.go:778] PR 21499 setting "Submit Queue" Github status to "Running github e2e tests a second time."
I0227 18:18:54.018711   30214 github.go:201] Made 2920 API calls since the last Reset 8.841398 calls/sec
I0227 18:18:54.018801   30214 mungegithub.go:71] Sleeping for 4m29.737228845s
I0227 18:23:23.756153   30214 mungegithub.go:57] Running mungers
I0227 18:28:29.853755   30214 github.go:778] PR 22133 setting "Submit Queue" Github status to "PR does not have LGTM."
I0227 18:28:29.946362   30214 github.go:201] Made 2893 API calls since the last Reset 5.023201 calls/sec
I0227 18:28:29.946470   30214 mungegithub.go:71] Sleeping for 4m53.809678613s
I0227 18:33:23.756276   30214 mungegithub.go:57] Running mungers
I0227 18:38:35.021151   30214 github.go:201] Made 2892 API calls since the last Reset 4.779575 calls/sec
I0227 18:38:35.021260   30214 mungegithub.go:71] Sleeping for 4m48.735010504s
I0227 18:43:23.756428   30214 mungegithub.go:57] Running mungers
I0227 18:46:04.939676   30214 github.go:778] PR 20446 setting "Submit Queue" Github status to "Github CI tests are not green."
I0227 18:47:06.260029   30214 github.go:778] PR 21593 setting "Submit Queue" Github status to "Github CI tests are not green."
I0227 18:48:36.407404   30214 github.go:201] Made 2891 API calls since the last Reset 4.807228 calls/sec
I0227 18:48:36.407489   30214 mungegithub.go:71] Sleeping for 4m47.348932174s
I0227 18:49:07.969280   30214 github.go:1070] Merging PR# 21499
I0227 18:49:07.969305   30214 github.go:1128] Commenting "Automatic merge from submit-queue" in 21499
I0227 18:49:08.514758   30214 github.go:778] PR 21499 setting "Submit Queue" Github status to "MERGED!"
I0227 18:49:10.146544   30214 github.go:1128] Commenting "@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]" in 21673
I0227 18:49:10.358929   30214 github.go:778] PR 21673 setting "Submit Queue" Github status to "Requested and waiting for github e2e test to start running a second time."
I0227 18:50:41.040997   30214 github.go:778] PR 21673 setting "Submit Queue" Github status to "Running github e2e tests a second time."
I0227 18:53:23.756539   30214 mungegithub.go:57] Running mungers
I0227 19:06:41.681553   30214 github.go:201] Made 3341 API calls since the last Reset 3.078485 calls/sec
I0227 19:06:41.681664   30214 mungegithub.go:74] Not sleeping as we took more than 10m0s to complete one loop
I0227 19:06:41.681686   30214 mungegithub.go:57] Running mungers
E0227 19:10:22.545977   30214 github.go:1190] no mergeability information for "Split factory#BindFlags" 21593, Skipping
E0227 19:10:24.883433   30214 github.go:1190] no mergeability information for "Split factory#BindFlags" 21593, Skipping
E0227 19:10:27.065761   30214 github.go:1190] no mergeability information for "Split factory#BindFlags" 21593, Skipping
E0227 19:10:29.238059   30214 github.go:1190] no mergeability information for "Split factory#BindFlags" 21593, Skipping
E0227 19:10:31.414332   30214 github.go:1190] no mergeability information for "Split factory#BindFlags" 21593, Skipping
I0227 19:10:31.489347   30214 github.go:778] PR 21593 setting "Submit Queue" Github status to "Unable to determine is PR is mergeable. Will try again later."
I0227 19:14:40.551497   30214 github.go:201] Made 3015 API calls since the last Reset 6.296074 calls/sec
I0227 19:14:40.551607   30214 mungegithub.go:71] Sleeping for 2m1.130080772s
I0227 19:16:41.681803   30214 mungegithub.go:57] Running mungers
I0227 19:21:18.265435   30214 github.go:1070] Merging PR# 21673
I0227 19:21:18.265469   30214 github.go:1128] Commenting "Automatic merge from submit-queue" in 21673
I0227 19:21:18.814787   30214 github.go:778] PR 21673 setting "Submit Queue" Github status to "MERGED!"
I0227 19:21:20.740694   30214 github.go:1128] Commenting "@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]" in 21728
I0227 19:21:20.940198   30214 github.go:778] PR 21728 setting "Submit Queue" Github status to "Requested and waiting for github e2e test to start running a second time."
I0227 19:21:21.154504   30214 github.go:778] PR 21728 setting "Submit Queue" Github status to "Running github e2e tests a second time."

[justinsb]

Issues affected:

#20273 ... just comment spam.
#20415 ... incorrectly removed LGTM. I re-added it.
#20446 ... my munger set the state of the Github CI tests. However, the integration tests do appear to have failed, so the state is correct, just the wrong account.
#20628... opened & closed an issue to trigger CI. Looks benign if not actively helpful.
#21499... my munger removed LGTM and then merged the PR. However, PR had already been queued for merge by the real munger, and had passed the tests. I believe this to be benign (though obviously very far from ideal)
#22133 ... state set to "PR does not have LGTM", but changed subsequently.
#21593... state set to "Github CI tests are not green". But then merged by real mergebot (correctly)
#21673 ... my munger removed LGTM and then Merged the PR. The PR did pass e2e testing, but I think it was not this PR's turn. Also, testing was likely not done in the correct sequence. I double-checked the PR and it looks good though, so I don't think we should revert it unless our tests now go red (and I'll keep an eye out)
#21728... removed LGTM. Readded LGTM.

[eparis]

--dry-run probably should be the default....

[0xmichalis]

/sig testing

[eparis]

closing. --dry-run is the default for a long long time.