Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2etest container conformance test #20415

Merged
merged 2 commits into from
Feb 29, 2016
Merged

E2etest container conformance test #20415

merged 2 commits into from
Feb 29, 2016

Conversation

liangchenye
Copy link
Contributor

blackbox test based on the pod interface exposed in 'client' .

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@k8s-bot
Copy link

k8s-bot commented Feb 1, 2016

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

1 similar comment
@k8s-bot
Copy link

k8s-bot commented Feb 1, 2016

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@k8s-github-robot
Copy link

Labelling this PR as size/L

@k8s-github-robot k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 1, 2016
@liangchenye
Copy link
Contributor Author

I signed it!


华为技术有限公司 Huawei Technologies Co., Ltd.
[Company_logo]

Mobile: 13426107977
Email: liangchenye@huawei.com
http://www.huawei.com


本邮件及其附件含有华为公司的保密信息,仅限于发送给上面地址中列出的个人或群组。禁
止任何其他人以任何形式使用(包括但不限于全部或部分地泄露、复制、或散发)本邮件中
的信息。如果您错收了本邮件,请您立即电话或邮件通知发件人并删除本邮件!
This e-mail and its attachments contain confidential information from HUAWEI, which
is intended only for the person or entity whose address is listed above. Any use of the
information contained herein in any way (including, but not limited to, total or partial
disclosure, reproduction, or dissemination) by persons other than the intended
recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by
phone or email immediately and delete it!

发件人: googlebot [mailto:notifications@github.com]
发送时间: 2016年2月1日 21:52
收件人: kubernetes/kubernetes
抄送: liangchenye
主题: Re: [kubernetes] E2etest container conformance test (#20415)

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

[:memo:]Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA datahttps://cla.developers.google.com/clas and verify that your email is set on your git commitshttps://help.github.com/articles/setting-your-email-in-git/.
  • If you signed the CLA as a corporation, please let us know the company's name.


Reply to this email directly or view it on GitHubhttps://github.com//pull/20415#issuecomment-177979007.

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Feb 1, 2016
@liangchenye
Copy link
Contributor Author

@pwittrock @Random-Liu , blackbox test bases on previous discussion.
Two testing container (one is valid, another fake one should be failed) .

@ixdy ixdy assigned pwittrock and unassigned ixdy Feb 2, 2016
@pwittrock
Copy link
Member

@liangchenye Thanks. I was out sick today and will take a look tomorrow.

@yifan-gu
Copy link
Contributor

yifan-gu commented Feb 3, 2016

subscribe @yifan-gu

@kevin-wangzefeng
Copy link
Member

/cc @kubernetes/huawei

@feiskyer
Copy link
Member

feiskyer commented Feb 3, 2016

CC @kubernetes/sig-node

}
}

func createContainer(cl *client.Client, container api.Container) error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this creates pods, lets name it createPod

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of always passing the client into the functions, create a struct and make these methods for that struct

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to use 'createContainer' since I want to test container, using pod is just the underling implementation way. Since new code will use method for struct, so it will just be 'Create'.

@dchen1107 dchen1107 added this to the v1.2 milestone Feb 4, 2016
@liangchenye
Copy link
Contributor Author

@pwittrock Thanks for correcting, commits with following updates:

  1. method with conformancecontainer struct
  2. two context
  3. better logs and descriptions

@k8s-bot
Copy link

k8s-bot commented Feb 4, 2016

GCE e2e build/test failed for commit d500cdf76d8d678dd64c94f75742f45caf7a1133.

@k8s-bot
Copy link

k8s-bot commented Feb 4, 2016

GCE e2e build/test failed for commit a4fbe9f1a1ee98791a4c2764d6e1c9e047183bd4.

@k8s-github-robot
Copy link

PR needs rebase

@k8s-github-robot k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 4, 2016
@pwittrock
Copy link
Member

@k8s-bot test node e2e experimental

1 similar comment
@pwittrock
Copy link
Member

@k8s-bot test node e2e experimental

@pwittrock
Copy link
Member

@pwittrock pwittrock added ok-to-merge lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-merge labels Feb 26, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Feb 27, 2016

GCE e2e build/test failed for commit e3861cd.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@k8s-bot
Copy link

k8s-bot commented Feb 27, 2016

GCE e2e build/test failed for commit e3861cd.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@justinsb
Copy link
Member

@pwittrock
You must link to the test flake issue which caused you to request this manual re-test.
Re-test requests should be in the form of: k8s-bot test this issue: #<number>
Here is the list of open test flakes.

@justinsb justinsb removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2016
@justinsb
Copy link
Member

I apologize for the above incorrect comments. I was working on the munger locally & it "went rogue" - see #22136. I am readding the LGTM label that was incorrectly removed.

@justinsb justinsb added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2016
@liangchenye
Copy link
Contributor Author

@k8s-bot test this issue: #21244

@k8s-bot
Copy link

k8s-bot commented Feb 29, 2016

GCE e2e build/test failed for commit e3861cd.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@k8s-bot
Copy link

k8s-bot commented Feb 29, 2016

GCE e2e build/test failed for commit e3861cd.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@liangchenye
Copy link
Contributor Author

@k8s-bot test this issue: #18738

@k8s-bot
Copy link

k8s-bot commented Feb 29, 2016

GCE e2e build/test failed for commit e3861cd.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@Random-Liu
Copy link
Member

@k8s-bot e2e test this, issue: #20916

@k8s-bot
Copy link

k8s-bot commented Feb 29, 2016

GCE e2e build/test passed for commit e3861cd.

@Random-Liu
Copy link
Member

@liangchenye Congrats! The test finally passed...:)

@liangchenye
Copy link
Contributor Author

@Random-Liu Thank you for the re-test help, time for the next PR now.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Feb 29, 2016

GCE e2e build/test passed for commit e3861cd.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Feb 29, 2016
@k8s-github-robot k8s-github-robot merged commit 89038f3 into kubernetes:master Feb 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet