Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate labels on node #2431

Closed
ddysher opened this issue Nov 18, 2014 · 5 comments
Closed

Duplicate labels on node #2431

ddysher opened this issue Nov 18, 2014 · 5 comments
Assignees

Comments

@ddysher
Copy link
Contributor

ddysher commented Nov 18, 2014

We have two sets of labels on internal node object: one is on the object (Minion.Labels), one is on object meta (Minion.ObjectMeta.Labels). We should remove Minion.Labels and fix the conversion properly?

@lavalamp
Copy link
Member

Yes.

@ddysher
Copy link
Contributor Author

ddysher commented Nov 18, 2014

ok, i'll take a look.

@ddysher ddysher self-assigned this Nov 18, 2014
@smarterclayton
Copy link
Contributor

Minions haven't been converted to v1beta3 internally - Mark or I had been planning on doing it, but if you're in place to do it by all means go ahead.

@ddysher
Copy link
Contributor Author

ddysher commented Nov 18, 2014

Sounds like it's more than just a duplicate label thing. How many work left? (#1519?)

I'm parttime on kubernetes, so I don't want to block you by any means. I'd love to offer some help, but your call :)

@smarterclayton
Copy link
Contributor

Nuke it by all means - just don't want mark or I to start working at the same time on it. :)

----- Original Message -----

Sounds like it's more than just a duplicate label thing. How many work left?
(#1519?)

I'm parttime on kubernetes, so I don't want to block you by any means. I'd
love to offer some help, but your call :)


Reply to this email directly or view it on GitHub:
#2431 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants