Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestWatchList {etcd3} #31300

Closed
k8s-github-robot opened this issue Aug 23, 2016 · 15 comments
Closed

TestWatchList {etcd3} #31300

k8s-github-robot opened this issue Aug 23, 2016 · 15 comments
Assignees
@timothysc @hongchaodeng @xiang90
Labels
kind/flake Categorizes issue or PR as related to a flaky test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@k8s-github-robot
Copy link

https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/kubernetes-test-go/16145/

Failed: TestWatchList {etcd3}

watcher_test.go:297: #4: time out after waiting 30s on ResultChan
watcher_test.go:297: #4: time out after waiting 30s on ResultChan
@k8s-github-robot k8s-github-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. kind/flake Categorizes issue or PR as related to a flaky test. labels Aug 23, 2016
@wojtek-t wojtek-t assigned timothysc, hongchaodeng and xiang90 and unassigned rmmh Aug 24, 2016
@wojtek-t
Copy link
Member

This is definitely related to this PR:
#30890

that switched unit tests to use v3 API of etcd.

@hongchaodeng @xiang90 @timothysc - seems like a blocker.

@lavalamp - FYI

@k82cn
Copy link
Member

k82cn commented Aug 28, 2016

Seems worked; did I miss anything?

$ make check WHAT=pkg/storage/etcd3
Running tests for APIVersion: v1,apps/v1alpha1,authentication.k8s.io/v1beta1,authorization.k8s.io/v1beta1,autoscaling/v1,batch/v1,batch/v2alpha1,certificates/v1alpha1,extensions/v1beta1,federation/v1beta1,policy/v1alpha1,rbac.authorization.k8s.io/v1alpha1,imagepolicy.k8s.io/v1alpha1
+++ [0828 09:56:45] Running tests without code coverage
ok      k8s.io/kubernetes/pkg/storage/etcd3     16.296s

@wojtek-t
Copy link
Member

@k82cn - first of all - this was a flake (it was failing only on some percentage of runs)
Second, we reverted the offending PR in: #31371

@k82cn
Copy link
Member

k82cn commented Aug 28, 2016

@wojtek-t , copy that, thanks a lot.

@aveshagarwal
Copy link
Member

Same: #31083

@aveshagarwal
Copy link
Member

The difference I see in the descriptions: TestWatchList and another is TestWatch.

@timothysc
Copy link
Member

This should be closed.. and #31704 aims to fix.

@mikedanese mikedanese mentioned this issue Sep 2, 2016
Merged
@piosz piosz reopened this Sep 2, 2016
@piosz
Copy link
Member

piosz commented Sep 2, 2016

This failed in pull builder https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/31961/kubernetes-pull-test-unit-integration/43070/

@piosz piosz mentioned this issue Sep 2, 2016
Merged
@k8s-github-robot
Copy link
Author

https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/kubernetes-test-go/16525/

Failed: TestWatchList {etcd3}

watcher_test.go:303: #3: time out after waiting 30s on ResultChan
watcher_test.go:303: #3: time out after waiting 30s on ResultChan

@hongchaodeng hongchaodeng mentioned this issue Sep 2, 2016
Merged
@k8s-github-robot
Copy link
Author

https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/kubernetes-test-go/16570/

Failed: TestWatchList {etcd3}

watcher_test.go:303: #2: time out after waiting 30s on ResultChan

@k8s-github-robot k8s-github-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/backlog Higher priority than priority/awaiting-more-evidence. labels Sep 3, 2016
k8s-github-robot pushed a commit that referenced this issue Sep 5, 2016
Merge pull request #32012 from hongchaodeng/f
7f3ce7b 
Automatic merge from submit-queue

Unshare cluster, store in each test suite

For #31962 and #31300.

Just try to unshare it to minimize interface and focus on correctness of logic.
@k8s-github-robot
Copy link
Author

[FLAKE-PING] @hongchaodeng @timothysc @xiang90

This flaky-test issue would love to have more attention.

@timothysc
Copy link
Member

timothysc commented Sep 6, 2016 •
edited
Loading

Is this still occurring? It seems like we're band-aiding for what are loaded gce env tests.

@k8s-github-robot
Copy link
Author

[FLAKE-PING] @hongchaodeng @timothysc @xiang90

This flaky-test issue would love to have more attention.

@timothysc
Copy link
Member

I'm inclined to close all the TestWatch issues and see which ones crop back up. There have been so many changes in the last week, I'm not sure if this is still an issue, or bot-annoyance.

@wojtek-t

@timothysc
Copy link
Member

I'm closing this one as it related to a long since reverted+fixed PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timothysc timothysc

@hongchaodeng hongchaodeng

@xiang90 xiang90

Labels
kind/flake Categorizes issue or PR as related to a flaky test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@timothysc @rmmh @hongchaodeng @aveshagarwal @xiang90 @wojtek-t @piosz @k8s-github-robot @k82cn