-
Notifications
You must be signed in to change notification settings - Fork 39k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable v3 Client as the default on UTs #30890
Conversation
e2232f6
to
828755a
Compare
Hmm I can't seem to reproduce these UT issues locally. I'll take a look in the a.m. |
@@ -415,7 +415,7 @@ func (s *ServerRunOptions) AddUniversalFlags(fs *pflag.FlagSet) { | |||
fs.MarkDeprecated("service-node-ports", "see --service-node-port-range instead") | |||
|
|||
fs.StringVar(&s.StorageConfig.Type, "storage-backend", s.StorageConfig.Type, | |||
"The storage backend for persistence. Options: 'etcd2' (default), 'etcd3'.") | |||
"The storage backend for persistence. Options: 'etcd2', 'etcd3' (default).") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as I'm probably fine with changing the default for tests in this PR, I don't think we should do it for binaries (since we still don't have rollback etc., so we may not able to launch it).
@lavalamp - thoughts?
I don't think we are ready to switch it on by default now (we don't have full migration, rollback, etc.). Though I'm probably fine with changing it for unit tests. @lavalamp - thoughts? |
I'll wait for the call on this one, and adjust the PR appropriately. |
Can we separate the unit test fixes into a separate PR? |
We definitely can't switch the global default like this right now. If you want to change the OSS setup scripts to start using etcd3, we can talk about that. But definitely we can't change the GKE setup at this point. Since different people need different settings, I think you have to plumb the setting through the setup code rather than actually flipping the flag default. |
Yeah I can simply modify this PR. |
828755a
to
36ac888
Compare
@timothysc - can you please take a look into test failures - these seem to be related. |
36ac888
to
bec9f4b
Compare
@k8s-bot test this please, issue #IGNORE |
OK - seems that test are passing now. Thanks! |
bec9f4b
to
a813f19
Compare
a813f19
to
99e0176
Compare
@wojtek-t @hongchaodeng forced rebase found a minor bug in the client that I patched around. |
LGTM |
@k8s-bot test this please, issue #IGNORE |
GCE e2e build/test passed for commit 99e0176. |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e build/test passed for commit 99e0176. |
Automatic merge from submit-queue |
Automatic merge from submit-queue cacher test: fix leftover v2 test server I think this was dismissed in #30890 @timothysc @wojtek-t
Updates the default initialization to use clientv3 interface to etcd3, and fixes the UTs.
This PR includes a cherry-pick of #30634 so we can validate the tests, so do not merge until that PR is complete.
This change is