Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic in the deployment controller #36488

Closed
0xmichalis opened this issue Nov 9, 2016 · 1 comment
Closed

Panic in the deployment controller #36488

0xmichalis opened this issue Nov 9, 2016 · 1 comment
Assignees
@0xmichalis
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Milestone
v1.5

Comments

@0xmichalis
Copy link
Contributor 

panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x79724d]

goroutine 960 [running]:
panic(0x2222440, 0xc420010030)
	/usr/local/go/src/runtime/panic.go:500 +0x1a1
k8s.io/kubernetes/pkg/util/runtime.HandleCrash(0x0, 0x0, 0x0)
	/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/util/runtime/runtime.go:56 +0x126
panic(0x2222440, 0xc420010030)
	/usr/local/go/src/runtime/panic.go:458 +0x243
k8s.io/kubernetes/pkg/controller/deployment.(*DeploymentController).syncRolloutStatus(0xc420ce8700, 0xc421c5c600, 0x2, 0x2, 0x0, 0xc422c41180, 0x0, 0x0)
	/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/controller/deployment/progress.go:123 +0x84d
k8s.io/kubernetes/pkg/controller/deployment.(*DeploymentController).rolloutRecreate(0xc420ce8700, 0xc422c41180, 0x26802d3, 0x8)
	/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/controller/deployment/recreate.go:45 +0x19a
k8s.io/kubernetes/pkg/controller/deployment.(*DeploymentController).syncDeployment(0xc420ce8700, 0xc421ec1300, 0x20, 0x0, 0x0)
	/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/controller/deployment/deployment_controller.go:389 +0x5e6
k8s.io/kubernetes/pkg/controller/deployment.(*DeploymentController).(k8s.io/kubernetes/pkg/controller/deployment.syncDeployment)-fm(0xc421ec1300, 0x20, 0xc421edecc0, 0xc4227f5de0)
	/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/controller/deployment/deployment_controller.go:117 +0x3e
k8s.io/kubernetes/pkg/controller/deployment.(*DeploymentController).worker.func1(0x453e00)
	/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/controller/deployment/deployment_controller.go:278 +0xfe
k8s.io/kubernetes/pkg/controller/deployment.(*DeploymentController).worker(0xc420ce8700)
	/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/controller/deployment/deployment_controller.go:285 +0x48
k8s.io/kubernetes/pkg/controller/deployment.(*DeploymentController).(k8s.io/kubernetes/pkg/controller/deployment.worker)-fm()
	/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/controller/deployment/deployment_controller.go:139 +0x2a
k8s.io/kubernetes/pkg/util/wait.JitterUntil.func1(0xc42086a950)
	/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/util/wait/wait.go:87 +0x5e
k8s.io/kubernetes/pkg/util/wait.JitterUntil(0xc42086a950, 0x3b9aca00, 0x0, 0x1, 0xc420046ae0)
	/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/util/wait/wait.go:88 +0xad
k8s.io/kubernetes/pkg/util/wait.Until(0xc42086a950, 0x3b9aca00, 0xc420046ae0)
	/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/util/wait/wait.go:49 +0x4d
created by k8s.io/kubernetes/pkg/controller/deployment.(*DeploymentController).Run
	/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/controller/deployment/deployment_controller.go:139 +0x1b7
I1109 04:04:59.078270       5 leaderelection.go:188] sucessfully acquired lease kube-system/kube-controller-manager

cc: @kubernetes/deployment

Found in #36286 (comment)
@0xmichalis 0xmichalis added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. component/deployment labels Nov 9, 2016
@0xmichalis 0xmichalis added this to the v1.5 milestone Nov 9, 2016
@0xmichalis 0xmichalis self-assigned this Nov 9, 2016
@0xmichalis 0xmichalis mentioned this issue Nov 9, 2016
Merged
@0xmichalis
Copy link
Contributor Author

Increasing the priority to P0 because it seems this is the issue behind most of the latest deployment flakes.

@0xmichalis 0xmichalis added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Nov 9, 2016
k8s-github-robot pushed a commit that referenced this issue Nov 9, 2016
Merge pull request #36491 from kargakis/panic-deployment-controller
5464d42 
Automatic merge from submit-queue

controller: fix panic in deployments

Fixes #36488

@kubernetes/deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xmichalis 0xmichalis

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
v1.5
Development

No branches or pull requests
1 participant
@0xmichalis