Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

controller: fix panic in deployments #36491

Merged
merged 1 commit into from
Nov 9, 2016
Merged

controller: fix panic in deployments #36491

merged 1 commit into from
Nov 9, 2016

Conversation

0xmichalis
Copy link
Contributor

@0xmichalis 0xmichalis commented Nov 9, 2016 •
edited by k8s-oncall
Loading

Fixes #36488

@kubernetes/deployment

This change is Reviewable

@0xmichalis 0xmichalis added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. labels Nov 9, 2016
@0xmichalis 0xmichalis added this to the v1.5 milestone Nov 9, 2016
@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 9, 2016
@mfojtik
Copy link
Contributor

mfojtik commented Nov 9, 2016

LGTM

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GCE e2e failed for commit 9fe910d. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@0xmichalis 0xmichalis added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2016
@0xmichalis
Copy link
Contributor Author

@k8s-bot unit test this #36473

@0xmichalis 0xmichalis added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Nov 9, 2016
@0xmichalis
Copy link
Contributor Author

@k8s-bot gci gce e2e test this #33380

@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit 9fe910d. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@0xmichalis
Copy link
Contributor Author

@k8s-bot unit test this #36473

This was referenced Nov 9, 2016
Closed
Closed
Closed
Closed
Closed
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 5464d42 into kubernetes:master Nov 9, 2016
@0xmichalis 0xmichalis deleted the panic-deployment-controller branch November 9, 2016 14:21
This was referenced Nov 10, 2016
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mfojtik mfojtik

Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@0xmichalis @mfojtik @k8s-ci-robot @k8s-github-robot @googlebot