Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CRI] dockershim networking umbrella issue #37316

Closed
4 of 5 tasks
freehan opened this issue Nov 22, 2016 · 27 comments
Closed
4 of 5 tasks

[CRI] dockershim networking umbrella issue #37316

freehan opened this issue Nov 22, 2016 · 27 comments
Assignees
@caseydavenport
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node.
Milestone
v1.7

Comments

@freehan
Copy link
Contributor

freehan commented Nov 22, 2016 •
edited
Loading

Umbrella issue for tracking CRI networking related tasks for k8s 1.6
@freehan freehan added sig/network Categorizes an issue or PR as relevant to SIG Network. team/cluster sig/node Categorizes an issue or PR as relevant to SIG Node. labels Nov 22, 2016
@freehan freehan added this to the next-candidate milestone Nov 22, 2016
@yujuhong
Copy link
Contributor

yujuhong commented Dec 7, 2016

One more item:

  • Support native docker networking

@freehan freehan mentioned this issue Dec 15, 2016
Merged
@resouer
Copy link
Contributor

resouer commented Dec 26, 2016 •
edited
Loading

@yujuhong docker native networking is a "docker specific" feature, how can we properly add it to k8s API? i.e., a filed named "network" only work for docker in pod spec will be wired...

@freehan
Copy link
Contributor Author

freehan commented Dec 27, 2016

@resouer network sig is working on defining the network object. As a first step, we just use the default network mode. See #38430

@resouer
Copy link
Contributor

resouer commented Dec 28, 2016

Em, that make sense, I think I must missed something. @freehan, Any existing doc or issue of network object handy?

@freehan
Copy link
Contributor Author

freehan commented Dec 28, 2016

@resouer It is still being drafted. see #27398 (comment)

@freehan
Copy link
Contributor Author

freehan commented Jan 10, 2017

refer: kubernetes/enhancements#54

@freehan freehan mentioned this issue Feb 16, 2017
Merged
k8s-github-robot pushed a commit that referenced this issue Feb 28, 2017
Merge pull request #41588 from freehan/cri-traffic-shaping
9f9f570 
Automatic merge from submit-queue (batch tested with PRs 41205, 42196, 42068, 41588, 41271)

[CRI] enable kubenet traffic shaping

ref: #37316

Another way to do this is to expose another interface in network host to allow network plugins to retrieve annotation. But that seems unnecessary and more complicated.
@yujuhong
Copy link
Contributor

@freehan I think this one can be closed.

@freehan
Copy link
Contributor Author

freehan commented Feb 28, 2017

Other CNI network plugins have not been tested with the CRI integration yet. And we are in the process of upgrading libcni (CNI library), calico guys are upgrading stuff and etc...

@squeed
Copy link
Contributor

squeed commented Feb 28, 2017

IIRC there were plans to turn kubenet in to a CNI plugin - is there an issue for that? Is that still part of the plan?

@freehan
Copy link
Contributor Author

freehan commented Feb 28, 2017

Turning kubenet into a CNI plugin is a long term plan. I think there is a issue somewhere. That is not a blocker for CRI in 1.6.

The CNI network plugin related item is mainly about ensuring CNI network plugin works with CRI.

@squeed
Copy link
Contributor

squeed commented Feb 28, 2017

Understood, thanks.

@yujuhong yujuhong modified the milestones: v1.6, next-candidate Feb 28, 2017
@yujuhong
Copy link
Contributor

Other CNI network plugins have not been tested with the CRI integration yet. And we are in the process of upgrading libcni (CNI library), calico guys are upgrading stuff and etc...

I see. I marked this 1.6 to help tracking the issues.

@dchen1107
Copy link
Member

What is the decision for the last item listed above: Now that kubenet works with CRI, make sure other CNI network plugins works too. Any tests / validation performed? compatible or not? Please note that CRI is enabled by default in OSS k8s.

cc/ @kubernetes/sig-network-misc

@dchen1107 dchen1107 modified the milestones: v1.6, v1.7 Mar 13, 2017
@dchen1107
Copy link
Member

I punt the last item to 1.7 milestone. But @freehan please do some validation tests with other CNI network plugins, and document the test results asap. This helps the release note too so that we can properly guide the users.

cc/ @devin-donnelly @calebamiles

@dchen1107
Copy link
Member

cc/ @derekwaynecarr

@cmluciano
Copy link

I can test out a few CNI plugins. Are there certain tests cases that should be run through ? @freehan @dchen1107 @yujuhong

@bowei
Copy link
Member

bowei commented Mar 27, 2017

@cmluciano @yujuhong -- can you document your test process if you are taking this on, I would like to get some idea of what an automated suite will look like

@yujuhong
Copy link
Contributor

@cmluciano @yujuhong -- can you document your test process if you are taking this on, I would like to get some idea of what an automated suite will look like

I don't have enough insight on what CNI plugins to test, but since this issue was re-targeted for 1.7, I think @freehan will be able to provide more input once he's back.

We don't have a dedicated "networking" test suite, I'd imagine if we had one, it should be either part of the node or cluster e2e suite. In general, the node e2e suite should give you the basic confidence for pod networking (of course the test coverage may not be complete, but that can always be improved).

@cmluciano
Copy link

Ok i will await freehan's response and start looking at the node e2e suite

@bboreham
Copy link
Contributor

The network e2e tests are concentrated in https://github.com/kubernetes/kubernetes/blob/master/test/e2e/networking.go

@freehan
Copy link
Contributor Author

freehan commented Apr 5, 2017

FYI,
PR #42202 is in flight to update cni network plugin to comply with CNI v0.5 spec.

@cmluciano
Here are some networking related tests you can start with:
Basic tests for pod-to-pod communication (support both in node and regular e2e): https://github.com/kubernetes/kubernetes/blob/master/test/e2e/common/networking.go

More comprehensive tests (only support regular e2e)
https://github.com/kubernetes/kubernetes/blob/master/test/e2e/networking.go
https://github.com/kubernetes/kubernetes/blob/master/test/e2e/service.go
https://github.com/kubernetes/kubernetes/blob/master/test/e2e/serviceloadbalancers.go

@thockin
Copy link
Member

thockin commented May 19, 2017

when do we close this?

@cmluciano
Copy link

I think this can be closed since the e2e testing of CNI plugins is tracked in kubernetes/kubeadm#218

/assign /close

@caseydavenport
Copy link
Member

/assign

@caseydavenport
Copy link
Member

/close

@caseydavenport
Copy link
Member

Try as we might, it seems this issue is not destined to be closed.

@cmluciano
Copy link

🤣

@thockin thockin closed this as completed May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caseydavenport caseydavenport

Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
v1.7
Development

No branches or pull requests
10 participants
@squeed @bowei @freehan @resouer @caseydavenport @cmluciano @thockin @dchen1107 @bboreham @yujuhong