Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #38814 #39079 release 1.5 #39137

Merged
merged 3 commits into from Dec 30, 2016
Merged

Automated cherry pick of #38814 #39079 release 1.5 #39137

merged 3 commits into from Dec 30, 2016

Conversation

jszczepkowski
Copy link
Contributor

@jszczepkowski jszczepkowski commented Dec 22, 2016 •
edited 

fixed cluster validation script for HA clusters

@jszczepkowski
Fixed infinite loop in cluster validation.
589c266 
Fixed infinite loop in cluster validation when getting nodes failed.
@jszczepkowski
Fixed cluster validation: added -q and project flags to gcloud.
d80d59c 
Fixed cluster validation in multi-zone mode: added -q and project flags to gcloud.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 22, 2016
@k8s-reviewable
Copy link

This change is Reviewable

@jszczepkowski jszczepkowski added this to the v1.5 milestone Dec 22, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins Bazel Build failed for commit d80d59c. Full PR test history.

The magic incantation to run this job again is @k8s-bot bazel test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit d80d59c. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE etcd3 e2e failed for commit d80d59c. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE Node e2e failed for commit d80d59c. Full PR test history.

The magic incantation to run this job again is @k8s-bot node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GCE e2e failed for commit d80d59c. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit d80d59c. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE e2e failed for commit d80d59c. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins Kubemark GCE e2e failed for commit d80d59c. Full PR test history.

The magic incantation to run this job again is @k8s-bot kubemark e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins CRI GCE Node e2e failed for commit d80d59c. Full PR test history.

The magic incantation to run this job again is @k8s-bot cri node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit d80d59c. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit d80d59c. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 22, 2016
@saad-ali saad-ali added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Dec 27, 2016
@saad-ali
Copy link
Member

Please rebase

@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 28, 2016
@jszczepkowski jszczepkowski added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 28, 2016
@jszczepkowski
Copy link
Contributor Author

@saad-ali
Rebease completed, all tests are green now.

@saad-ali saad-ali mentioned this pull request Dec 28, 2016
Merged
@saad-ali
Copy link
Member

@kubernetes/test-infra-maintainers Any idea why the submit queue is not picking up this PR? All checks look green:

@k8s-merge-robot  Submit Queue — Required Github CI test is not green: Jenkins Bazel Build
Details@k8s-ci-robot  Jenkins CRI GCE Node e2e — Build succeeded.
Details@k8s-ci-robot  Jenkins GCE Node e2e — Build succeeded.
Details@k8s-ci-robot  Jenkins GCE e2e — Build succeeded.
Details@k8s-ci-robot  Jenkins GCE etcd3 e2e — Build succeeded.
Details@k8s-ci-robot  Jenkins GCI GCE e2e — Build succeeded.
Details@k8s-ci-robot  Jenkins GCI GKE smoke e2e — Build succeeded.
Details@k8s-ci-robot  Jenkins GKE smoke e2e — Build succeeded.
Details@k8s-ci-robot  Jenkins Kubemark GCE e2e — Build succeeded.
Details@k8s-ci-robot  Jenkins unit/integration — Build succeeded.
Details@k8s-ci-robot  Jenkins verification — Build succeeded.
Details@thelinuxfoundation  cla/linuxfoundation — jszczepkowski authorized

@saad-ali
Copy link
Member

@k8s-bot bazel test this

@ixdy
Copy link
Member

ixdy commented Dec 29, 2016

@saad-ali you figured it out, but SQ actually tells you, though for some reason you have to click on the "PRs" tab: http://submit-queue.k8s.io/#/prs?prDisplay=39137&historyDisplay=39137

@ixdy
Copy link
Member

ixdy commented Dec 29, 2016

Ah, the link on GitHub is subtly wrong. kubernetes-retired/contrib#2232 to fix.

@spxtr
Copy link
Contributor

spxtr commented Dec 29, 2016

Oh, I suggest merging this by hand. kubernetes/test-infra#1436 added the ability to only run tests against certain branches, but it doesn't even set a green checkmark. I'll make a fix today.

@spxtr
Copy link
Contributor

spxtr commented Dec 29, 2016

@k8s-bot bazel test this

@spxtr
Copy link
Contributor

spxtr commented Dec 29, 2016

OK, it says "Skipped" now :)

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 35159e4 into kubernetes:release-1.5 Dec 30, 2016
@saad-ali saad-ali mentioned this pull request Dec 30, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saad-ali saad-ali saad-ali approved these changes

Assignees

@saad-ali saad-ali

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jszczepkowski @k8s-reviewable @k8s-ci-robot @saad-ali @ixdy @spxtr @k8s-github-robot