Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multipathing has to be supported in iscsi plugin. #39345

Closed
humblec opened this issue Jan 2, 2017 · 16 comments
Closed

Multipathing has to be supported in iscsi plugin. #39345

humblec opened this issue Jan 2, 2017 · 16 comments
Assignees
@rootfs
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/storage Categorizes an issue or PR as relevant to SIG Storage.

Comments

@humblec
Copy link
Contributor

humblec commented Jan 2, 2017

iic, most of the iscsi targets provide multipathing using multiple iscsi target portals for the same IQN , thus multiple paths through initiator connections in each of it. However, kube iscsi plugin is not capable of receiving multiple TPs in its volume spec, thus lack this functionality. If iscsi volume spec.target portal can receive an array of IPs or IPs:Port instead of single value, the mounter can try to login in each path and get the mpath/mpio device created in the kubelet. but this require an API change.

Any thoughts on this ?
@humblec
Copy link
Contributor Author

humblec commented Jan 2, 2017

@rootfs PTAL.

@humblec humblec changed the title multipathing has to be supported in iscsi plugin. Multipathing has to be supported in iscsi plugin. Jan 2, 2017
@humblec
Copy link
Contributor Author

humblec commented Jan 3, 2017 •
edited
Loading

Can multipathed iscsi target have different Lun numbers.? For ex:

TP-1, IQN-X, Lun-0
TP-2, IQN-X, Lun-1 ..etc?

iic, its possible eventhough admins wont configure that way. If that is the case, we cannot just change the TP field in volume spec to an array and get this resolved. It need to accommodate different Lun numbers ..etc .. Any thoughts ?

@rootfs
Copy link
Contributor

rootfs commented Jan 3, 2017

@fabiand

@calebamiles calebamiles added kind/feature Categorizes issue or PR as related to a new feature. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Jan 4, 2017
@humblec
Copy link
Contributor Author

humblec commented Jan 6, 2017

@fabiand Did you get a chance to look at this ?

@fabiand
Copy link
Contributor

fabiand commented Jan 6, 2017

@humblec No, sadly not.

@humblec
Copy link
Contributor Author

humblec commented Jan 10, 2017

@rootfs @fabiand it looks to me that, multiple TP is good enough to achieve this goal. As long as we are 'logging in' all the available targets ( by a api spec change of TP from string to array) we should be able to bring the mpath support with iscsi. What do you think?

@fabiand
Copy link
Contributor

fabiand commented Jan 11, 2017

👍 I think the change is simple - and I'd have done it the same way, by changing to a list of strings.

@raklez6
Copy link

raklez6 commented Jan 12, 2017

I'm running into issue badly. If you have the cod change or a patch, i will be happy to test it out.

@humblec
Copy link
Contributor Author

humblec commented Jan 13, 2017

Thanks. Let me give a try. 👍

@fabiand
Copy link
Contributor

fabiand commented Jan 13, 2017

Could this actually be an dupe of #21306 ?

@humblec humblec mentioned this issue Jan 15, 2017
Merged
@humblec
Copy link
Contributor Author

humblec commented Jan 15, 2017

@fabiand Thanks, yes, this looks to be a duplicate. I tried to bring the multipath support by adding backup portal as discussed in @21306.

k8s-github-robot pushed a commit that referenced this issue Feb 13, 2017
Merge pull request #39928 from humblec/iscsi-multipath-backuptp
a75b61d 
Automatic merge from submit-queue

Add mulitpath support to iscsi plugin

#issue #39345
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec
Copy link
Contributor Author

humblec commented Feb 16, 2017

@fabiand The PR is merged in master and should be available from 1.6 :). Thanks!

@fabiand
Copy link
Contributor

fabiand commented Feb 16, 2017

Kudos!

@fabiand
Copy link
Contributor

fabiand commented Jun 12, 2017

Can this bug get closed?

@rootfs
Copy link
Contributor

rootfs commented Jun 12, 2017

/assign

@rootfs
Copy link
Contributor

rootfs commented Jun 12, 2017

/close

perotinus pushed a commit to kubernetes-retired/cluster-registry that referenced this issue Sep 2, 2017
Merge pull request #39928 from humblec/iscsi-multipath-backuptp
84801c6 
Automatic merge from submit-queue

Add mulitpath support to iscsi plugin

#issue kubernetes/kubernetes#39345
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@rootfs rootfs mentioned this issue Jul 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootfs rootfs

Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/storage Categorizes an issue or PR as relevant to SIG Storage.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@fabiand @calebamiles @humblec @raklez6 @rootfs @k8s-ci-robot