Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: OpenAPI types are missing some fields #39465

Closed
mbohlool opened this issue Jan 5, 2017 · 2 comments
Closed

Bug: OpenAPI types are missing some fields #39465

mbohlool opened this issue Jan 5, 2017 · 2 comments
Assignees
@mbohlool
Labels
area/api Indicates an issue on api area. area/swagger kind/bug Categorizes issue or PR as related to a bug. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@mbohlool
Copy link
Contributor

mbohlool commented Jan 5, 2017 •
edited
Loading

Discovered in kubernetes-client/python#85

Some types are missing fields in generated OpenAPI spec. For example v1.ConfigMapKeySelector is missing a Name field. This is due to ignoring fields with empty json name tag while most (if not all) of these members also have "inline" tag meaning we should inline their members into the generated type.

cc @kubernetes/sig-api-machinery-misc
@mbohlool mbohlool added area/api Indicates an issue on api area. area/swagger kind/bug Categorizes issue or PR as related to a bug. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jan 5, 2017
@mbohlool mbohlool self-assigned this Jan 5, 2017
@mbohlool
Copy link
Contributor Author

mbohlool commented Jan 5, 2017

@lavalamp I have a fix for this. python client is set to generate client only from a kubernetes release branch. I suggest we cherry-pick the fix into 1.5 release branch, what do you think?

This was referenced Jan 9, 2017
Closed
Merged
@mbohlool
Copy link
Contributor Author

mbohlool commented Jan 9, 2017

Fixed by #39466, cherrypick into 1.5 by #39549.

mbohlool added a commit to mbohlool/client-python that referenced this issue Jan 10, 2017
@mbohlool
Update generated client after bugfix kubernetes/kubernetes#39465
d1a8517
@mbohlool mbohlool mentioned this issue Jan 10, 2017
Merged
mbohlool added a commit to mbohlool/client-python that referenced this issue Jan 10, 2017
@mbohlool
Update generated client after bugfix kubernetes/kubernetes#39465
b971b6b
mbohlool added a commit to kubernetes-client/python that referenced this issue Jan 10, 2017
@mbohlool
Merge pull request #90 from mbohlool/master
cd2342d 
Update generated client after bugfix kubernetes/kubernetes#39465
abdul5497 pushed a commit to abdul5497/python-dapp that referenced this issue Apr 1, 2024
Update generated client after bugfix kubernetes/kubernetes#39465
4c1ec6b
abdul5497 pushed a commit to abdul5497/python-dapp that referenced this issue Apr 1, 2024
Merge pull request #90 from mbohlool/master
e765012 
Update generated client after bugfix kubernetes/kubernetes#39465
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbohlool mbohlool

Labels
area/api Indicates an issue on api area. area/swagger kind/bug Categorizes issue or PR as related to a bug. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mbohlool