Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #39466 #39549

Merged
merged 2 commits into from
Jan 10, 2017
Merged

Automated cherry pick of #39466 #39549

merged 2 commits into from
Jan 10, 2017

Conversation

mbohlool
Copy link
Contributor

@mbohlool mbohlool commented Jan 6, 2017

Cherry pick of #39466 on release-1.5.

#39466: Generate inlined member's OpenAPI definitions

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 6, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 6, 2017
@mbohlool mbohlool assigned saad-ali and unassigned lavalamp Jan 6, 2017
@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit efa7679. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit efa7679. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@saad-ali saad-ali added this to the v1.5 milestone Jan 7, 2017
@saad-ali saad-ali added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jan 7, 2017
@saad-ali
Copy link
Member

saad-ali commented Jan 7, 2017

@k8s-bot cri node e2e test this

@saad-ali
Copy link
Member

saad-ali commented Jan 7, 2017

@k8s-bot node e2e test this

@saad-ali
Copy link
Member

saad-ali commented Jan 7, 2017

@k8s-bot unit test this

@saad-ali
Copy link
Member

saad-ali commented Jan 7, 2017

@k8s-bot cvm gke e2e test this

@saad-ali
Copy link
Member

saad-ali commented Jan 7, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2017
@mbohlool
Copy link
Contributor Author

mbohlool commented Jan 7, 2017

@k8s-bot cri node e2e test this

@mbohlool
Copy link
Contributor Author

mbohlool commented Jan 7, 2017

@k8s-bot node e2e test this

@mbohlool
Copy link
Contributor Author

mbohlool commented Jan 7, 2017

@k8s-bot cri node e2e test this

@mbohlool
Copy link
Contributor Author

mbohlool commented Jan 7, 2017

@k8s-bot node e2e test this

@k8s-ci-robot
Copy link
Contributor

Jenkins CRI GCE Node e2e failed for commit efa7679. Full PR test history.

The magic incantation to run this job again is @k8s-bot cri node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mbohlool
Copy link
Contributor Author

mbohlool commented Jan 8, 2017

Both tests are consistently failing with "unable to create gce instance with running docker daemon for image coreos-alpha-1122-0-0-v20160727. instance tmp-node-e2e-69c255e4-coreos-alpha-1122-0-0-v20160727 not running docker daemon - Command failed: Permission denied, please try again." I am not sure how to fix it, but it seems to be unrelated to this PR.

@mbohlool mbohlool mentioned this pull request Jan 9, 2017
Closed
@mbohlool
Copy link
Contributor Author

mbohlool commented Jan 9, 2017

@k8s-bot node e2e test this

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE Node e2e failed for commit efa7679. Full PR test history.

The magic incantation to run this job again is @k8s-bot node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mbohlool
Copy link
Contributor Author

mbohlool commented Jan 9, 2017

@saad-ali These two tests are consistently failing. I see a flaky test issue #35983 but I guess this is either a new instance of the issue or it is only happening on release branch. Do you know the next steps? As other tests are passing and this PR is only an spec change, can we merge it anyway?

@mbohlool
Copy link
Contributor Author

mbohlool commented Jan 9, 2017

#39597

@mbohlool
Copy link
Contributor Author

mbohlool commented Jan 9, 2017

@k8s-bot node e2e test this

@mbohlool
Copy link
Contributor Author

mbohlool commented Jan 9, 2017

@k8s-bot cri node e2e test this

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 660c2a2 into kubernetes:release-1.5 Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@saad-ali saad-ali

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mbohlool @k8s-reviewable @k8s-ci-robot @saad-ali @k8s-github-robot @lavalamp