Default Storage Classes can't easily be disabled #39561
Comments
saad-ali
added
the
sig/storage
|
@mikedanese another call for addon manager to distinguish initial values
from re-asserted values.
…On Fri, Jan 6, 2017 at 6:01 PM, Saad Ali ***@***.***> wrote:
PR https://github.com/kubernetes/kubernetes/pull/31617/files introduced
default storage classes for 1.6. They are created with cluster addon which
can not easily be modified by end users (requires access to the master).
We should improve experience before 1.6 goes out.
CC @kubernetes/sig-storage-misc
<https://github.com/orgs/kubernetes/teams/sig-storage-misc>
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#39561>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AFVgVAybLiaYg14LhlDdfo0t_EgrVJ27ks5rPvHvgaJpZM4LdS3s>
.
|
|
@msau42 can help out with this |
|
@MrHohn @mikedanese who among us feels the most ownership of addon
manager? This is reaching a boiling point.
…On Wed, Jan 11, 2017 at 3:26 PM, Saad Ali ***@***.***> wrote:
@msau42 <https://github.com/msau42> can help out with this
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#39561 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFVgVAYw8s87qt63mJQjP5YAJ1540dzsks5rRWU_gaJpZM4LdS3s>
.
|
|
As @mikedanese mentioned before, it wouldn't be hard to implement an "oneshot" functionality. I also had a short proposal for this. If we agree this is the proper way to go with, I can also help out. The required work I expect would be putting couple more startup logics into kube-addon.sh that carefully handle upgrade/restart cases. |
|
Other that StorageClass (which I guess an admin *might* want to remove) I
don't think oneshot is what we want. Maybe we just want to ensure that an
object exists and if it doesn't, create it with a known base-config. Is
that sufficient?
…On Wed, Jan 11, 2017 at 11:06 PM, Zihong Zheng ***@***.***> wrote:
As @mikedanese <https://github.com/mikedanese> mentioned before
<#34639 (comment)>,
it wouldn't be hard to implement an "oneshot" functionality. I also had a
short proposal
<#34639 (comment)>
for this.
If we agree this is the proper way to go with, I can also help out. The
required work I expect would be putting couple more startup logics into
kube-addon.sh
<https://github.com/kubernetes/kubernetes/blob/master/cluster/addons/addon-manager/kube-addons.sh>
that carefully handle upgrade/restart cases.
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#39561 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFVgVDgefO9HwhtP6Flw-I-tM7CMMU91ks5rRdEPgaJpZM4LdS3s>
.
|
|
Ensure exist sounds good. What about two classes: one that reconcile, the other ensure exist? |
|
That sounds acceptable. We mainly need:
I think it is ok if the deletion case is not supported. Changing the default-class is sufficient to get the behavior we want. |
5 tasks
|
@msau42, can I help you in any way? I know very little about addon manager and its internals. |
|
Thanks, I plan to coordinate with addon folks to make the change. It may end up being that all the changes are only in the addon component. |
17 tasks
k8s-github-robot
pushed a commit
that referenced
this issue
Feb 25, 2017
Automatic merge from submit-queue Supports 'ensure exist' class addon in Addon-manager Fixes #39561, fixes #37047 and fixes #36411. Depends on #40057. This PR splits cluster addons into two categories: - Reconcile: Addons that need to be reconciled (`kube-dns` for instance). - EnsureExists: Addons that need to be exist but changeable (`default-storage-class`). The behavior for the 'EnsureExists' class addon would be: - Create it if not exist. - Users could do any modification they want, addon-manager will not reconcile it. - If it is deleted, addon-manager will recreate it with the given template. - It will not be updated/clobbered during upgrade. As Brian pointed out in [#37048/comment](#37048 (comment)), this may not be the best solution for addon-manager. Though #39561 needs to be fixed in 1.6 and we might not have enough bandwidth to do a big surgery. @mikedanese @thockin cc @kubernetes/sig-cluster-lifecycle-misc --- Tasks for this PR: - [x] Supports 'ensure exist' class addon and switch to use new labels in addon-manager. - [x] Updates READMEs regarding the new behavior of addon-manager. - [x] Updated `test/e2e/addon_update.go` to match the new behavior. - [x] Go through all current addons and apply the new labels on them regarding what they need. - [x] Bump addon-manager and update its template files.
dims
pushed a commit
to dims/kubernetes
that referenced
this issue
Feb 8, 2018
Automatic merge from submit-queue Supports 'ensure exist' class addon in Addon-manager Fixes kubernetes#39561, fixes kubernetes#37047 and fixes kubernetes#36411. Depends on kubernetes#40057. This PR splits cluster addons into two categories: - Reconcile: Addons that need to be reconciled (`kube-dns` for instance). - EnsureExists: Addons that need to be exist but changeable (`default-storage-class`). The behavior for the 'EnsureExists' class addon would be: - Create it if not exist. - Users could do any modification they want, addon-manager will not reconcile it. - If it is deleted, addon-manager will recreate it with the given template. - It will not be updated/clobbered during upgrade. As Brian pointed out in [kubernetes#37048/comment](kubernetes#37048 (comment)), this may not be the best solution for addon-manager. Though kubernetes#39561 needs to be fixed in 1.6 and we might not have enough bandwidth to do a big surgery. @mikedanese @thockin cc @kubernetes/sig-cluster-lifecycle-misc --- Tasks for this PR: - [x] Supports 'ensure exist' class addon and switch to use new labels in addon-manager. - [x] Updates READMEs regarding the new behavior of addon-manager. - [x] Updated `test/e2e/addon_update.go` to match the new behavior. - [x] Go through all current addons and apply the new labels on them regarding what they need. - [x] Bump addon-manager and update its template files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
PR https://github.com/kubernetes/kubernetes/pull/31617/files introduced default storage classes for 1.6. They are created with cluster addon which can not easily be modified by end users (requires access to the master).
We should improve experience before 1.6 goes out.
CC @kubernetes/sig-storage-misc
The text was updated successfully, but these errors were encountered: