Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove APIServerList from the Kubelet #40049

Closed
mtaufen opened this issue Jan 18, 2017 · 4 comments
Closed

Remove APIServerList from the Kubelet #40049

mtaufen opened this issue Jan 18, 2017 · 4 comments
Assignees
@mtaufen
Labels
area/kubelet area/kubelet-api sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@mtaufen
Copy link
Contributor

mtaufen commented Jan 18, 2017 •
edited

I would remove this right now, as it has been marked deprecated since 1.4. However, as (len(s.APIServerList) == 0 && !s.RequireKubeConfig) is the criteria for enabling standalone mode on the Kubelet, a replacement flag needs to be around for two versions before the deprecated flag can be removed. I will post a PR for 1.6 to add the replacement --standalone flag (unless @kubernetes/sig-cluster-lifecycle-misc has determined other plans since this was last discussed). The removal of APIServerList can then happen in 1.8.

/cc @mikedanese @errordeveloper

Edit: #40050 accomplishes the removal of --api-servers
@mtaufen mtaufen added area/kubelet area/kubelet-api sig/node Categorizes an issue or PR as relevant to SIG Node. labels Jan 18, 2017
@mtaufen mtaufen self-assigned this Jan 18, 2017
@mtaufen mtaufen mentioned this issue Jan 18, 2017
Merged
@mtaufen
Copy link
Contributor Author

mtaufen commented Jan 18, 2017

xref: #40050

@liggitt
Copy link
Member

liggitt commented Jan 18, 2017

Hmm. Is the default path for --kubeconfig the issue? Seems like if --kubeconfig had no default, it's absence would mean standalone and presence would replace --require-kubeconfig

@mtaufen
Copy link
Contributor Author

mtaufen commented Jan 18, 2017 •
edited

The issue is more that an alternative way for specifying standalone mode hasn't been in place for the same period of time that APIServerList has been deprecated, so even though people have been told not to use it, there is really no alternative for enabling standalone mode - so we can't just rip it out because we'll risk breaking people when they move to a new k8s version.

As far as how we provide an alternative, I'd rather be explicit with the setting. It's more clear to users.

@mikedanese
Copy link
Member

This is related to #30515 cc @smarterclayton

k8s-github-robot pushed a commit that referenced this issue Jul 25, 2017
Merge pull request #40050 from mtaufen/standalone-mode
2189314 
Automatic merge from submit-queue (batch tested with PRs 48976, 49474, 40050, 49426, 49430)

Use presence of kubeconfig file to toggle standalone mode

Fixes #40049 

```release-note
The deprecated --api-servers flag has been removed. Use --kubeconfig to provide API server connection information instead. The --require-kubeconfig flag is now deprecated. The default kubeconfig path is also deprecated. Both --require-kubeconfig and the default kubeconfig path will be removed in Kubernetes v1.10.0.
```

/cc @kubernetes/sig-cluster-lifecycle-misc @kubernetes/sig-node-misc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtaufen mtaufen

Labels
area/kubelet area/kubelet-api sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mtaufen @liggitt @mikedanese