-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix service spec for kube api server #41115
fix service spec for kube api server #41115
Conversation
…ses the service port itself. The endpoint is created correctly using public port. Fix the service also because there are some plugin controllers that react to service spec itself.
This change is needed by contiv, a CNI networking plugin for Openshift in order to watch and program the correct endpoint port number for the kubernetes api server. |
LGTM. |
@derekwaynecarr PTAL |
@smarterclayton Review please |
Lgtm as well but want @ncdc to sign off as well |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED The following people have approved this PR: rajatchopra, smarterclayton Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Automatic merge from submit-queue |
For the auto generated kube api-server service, the service spec re-uses the service port itself. The endpoint is created correctly using public port. Fix the service also because there are some plugin controllers that react to service spec itself.
Before fix:
After fix: