Multi master patch #41351
Multi master patch #41351
Conversation
k8s-github-robot
added
the
approved
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
size/L
|
This change is |
|
I don't see any problems with this patch, but I can't test juju-based clusters at the moment. I already mentioned this in another PR, but maybe I'm should be removed from the reviewer list of this directory? |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
@ivan4th - I'll make sure to follow up and issue a PR removing you from the reviewers list. Thanks for letting us know you're not comfortable reviewing these submissions. I'm happy to remove you and should you ever feel comfortable moving forward just issue an incoming PR and let me know so I can +1 :) |
|
@k8s-bot gce etcd3 e2e test this |
|
@k8s-bot bazel test this |
|
Fantastic this looks good now. I don't see a follow up that it's on it's way to the submit queue however, and based on PR #41256 it seems like our contributions are stuck in a limbo. |
|
Limbo averted. things are progressing 🎉 |
k8s-github-robot
added
the
needs-rebase
This branch sync's the crypto keys, and flat-files used for auth with all the masters when scaling the kubernetes-master units. This should fix the mis-matched crypto keys seen when rebooting units after first deploy.
lazypower
force-pushed
the
multi-master-patch
branch
from
bb24e14
to
4408b82
Compare
k8s-github-robot
removed
lgtm
|
@ivan4th - I got ninja'd by another branches lint fixes (hence the rebase). Once I've got the tests settled I'll re-ping for re LGTM label. Thanks for supporting this branch until landing. |
|
Minor flake here - @k8s-bot verify test this -- edit -- this doesn't appear to have an open flake against it, but is also the first time I've seen this particular test failure. Will open a bug if it continues to be a problem. |
Per ivans request in kubernetes#41351 he would like to be removed from the reviewers list in this directory tree. This commit addresses that request.
|
upstream issue seems resolved. giving this another go @k8s-bot verify test this |
|
@ivan4th - ok this looks ready to re-review/LGTM again. all the tests have passed and the merge conflict is resolved. Thanks! |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED The following people have approved this PR: chuckbutler, ivan4th Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Automatic merge from submit-queue Remove ivan4th from reviewers **What this PR does / why we need it**: Per @ivan4th request in #41351 he would like to be removed from the reviewers list in this directory tree. This commit addresses that request. **Special notes for your reviewer**: As Ivan has already investigated the PR in question under 41351 I would like to see that driven to landing before landing this OWNERS file change, unless another reviewer would like to step in and help land that open PR. **Release note**: ```release-note NONE ```
|
This change has been reviewed and approved days ago. Now this is getting"Jenkins overloaded" messages. We do want to get this change in before code freeze as it is an important fix for our cluster. @k8s-bot gce etcd3 e2e test this |
|
@k8s-bot node e2e test this |
|
All the required tests have passed. I see this PR in the submit queue! Yeah! |
|
Automatic merge from submit-queue (batch tested with PRs 40665, 41094, 41351, 41721, 41843) |
What this PR does / why we need it: Corrects a sync files issue present when running in a HA Master configuration. This PR adds logic to syncronize on first deployment for
/etc/kubernetes/serviceaccount.keywhich will cause cypto verification failure if not 1:1 on each master unit. Additionally syncs basic_auth and additional files in /srv/kubernetes.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #41019Special notes for your reviewer: This requires PR #41251 as a dependency before merging.
Release note: