client-go: don't import client auth provider packages

[ericchiang]

Both of these auth providers are useful for kubectl but not so much for everyone importing client-go. Let users optionally import them (example [0]) and reduce the overall number of imports that client-go requires.

Quick grep seems to imply it wont import it after.

$ grep -r 'client-go/plugin/pkg/client/auth' staging/
staging/src/k8s.io/client-go/plugin/pkg/client/auth/plugins.go:	_ "k8s.io/client-go/plugin/pkg/client/auth/gcp"
staging/src/k8s.io/client-go/plugin/pkg/client/auth/plugins.go:	_ "k8s.io/client-go/plugin/pkg/client/auth/oidc"
staging/src/k8s.io/client-go/examples/third-party-resources/main.go:	_ "k8s.io/client-go/plugin/pkg/client/auth/gcp"
staging/src/k8s.io/kube-aggregator/pkg/client/clientset_generated/clientset/clientset.go:	_ "k8s.io/client-go/plugin/pkg/client/auth"
staging/src/k8s.io/kube-aggregator/pkg/client/clientset_generated/internalclientset/clientset.go:	_ "k8s.io/client-go/plugin/pkg/client/auth"

closes kubernetes/client-go#49
updates kubernetes/client-go#79 (removes cloud.google.com/go import)

cc @kubernetes/sig-api-machinery-pr-reviews @kubernetes/sig-auth-pr-reviews

client-go no longer imports GCP OAuth2 and OpenID Connect packages by default.

[0] https://github.com/kubernetes/client-go/blob/8b466d64c5da37e0d3985b907d812e1f58cb41cb/examples/third-party-resources/main.go#L34-L35

[k8s-reviewable]

This change is 

[ericchiang]

Removes 23 package dependencies (not projects) from k8s.io/client-go/kubernetes.

$ go list -f '{{.Deps}}' k8s.io/client-go/kubernetes | tr "[" " " | tr "]" " " | xargs go list -f '{{if not .Standard}}{{.ImportPath}}{{end}}'  | wc -l
168
$ git checkout kubectl-auth-providers 
Switched to branch 'kubectl-auth-providers'
$ go list -f '{{.Deps}}' k8s.io/client-go/kubernetes | tr "[" " " | tr "]" " " | xargs go list -f '{{if not .Standard}}{{.ImportPath}}{{end}}'  | wc -l
145

[sttts]

Proposed the same change before. Lgtm, but let somebody from sig-auth take a look.

[caesarxuchao]

Partially adress kubernetes/client-go#95.

[caesarxuchao]

Thanks @ericchiang.

[caesarxuchao]

/lgtm
/approve

[sttts]

This file is generated, compare

kubernetes/cmd/libs/go2idl/client-gen/generators/generator_for_clientset.go

Line 67 in 2734f8f

imports = append(imports, "_ \"k8s.io/client-go/plugin/pkg/client/auth\"")

[sttts]

I.e. please change the generator.

[ericchiang]

updated.

[caesarxuchao]

Nice catch!

[caesarxuchao]

/lgtm

[caesarxuchao]

@lavalamp could you approve the change? Thanks.

[ericchiang]

rebased

[caesarxuchao]

@lavalamp could you approve the change? Thanks.

[smarterclayton]

/approve

…

On Tue, Feb 21, 2017 at 12:47 PM, Chao Xu ***@***.***> wrote: @lavalamp <https://github.com/lavalamp> could you approve the change? Thanks. — You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub <#41532 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABG_p80WTuC6cUF_7NLciwh0UH7PXnR5ks5reyMtgaJpZM4MClXd> .

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: caesarxuchao, ericchiang, smarterclayton

Needs approval from an approver in each of these OWNERS Files:

• OWNERS [smarterclayton]
• cmd/kubectl/OWNERS [smarterclayton]
• cmd/libs/go2idl/client-gen/OWNERS [caesarxuchao,smarterclayton]
• federation/OWNERS [smarterclayton]
• pkg/client/OWNERS [caesarxuchao,smarterclayton]
• staging/src/k8s.io/client-go/OWNERS [caesarxuchao,smarterclayton]
• staging/src/k8s.io/kube-aggregator/OWNERS [smarterclayton]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[ericchiang]

@k8s-bot cvm gce e2e test this

[k8s-github-robot]

Automatic merge from submit-queue (batch tested with PRs 41349, 41532, 41256, 41587, 41657)