Reduce replication_controller log spam #44391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
@sttts assuming this gets approved, let's pick it |
|
This change is |
|
Should it also be gated on: |
|
/lgtm Thanks! |
k8s-ci-robot
added
the
lgtm
sttts
added
the
approved
|
|
0xmichalis
removed
the
lgtm
0xmichalis
reviewed
Apr 12, 2017
| @@ -202,8 +202,7 @@ func (rm *ReplicationManager) updateRC(old, cur interface{}) { | |||
| oldRC := old.(*v1.ReplicationController) | |||
| curRC := cur.(*v1.ReplicationController) | |||
|
|
|||
| // TODO: Remove when #31981 is resolved! | |||
| glog.Infof("Observed updated replication controller %v. Desired pod count change: %d->%d", curRC.Name, *(oldRC.Spec.Replicas), *(curRC.Spec.Replicas)) | |||
| glog.V(4).Infof("Observed updated replication controller %v. Desired pod count change: %d->%d", curRC.Name, *(oldRC.Spec.Replicas), *(curRC.Spec.Replicas)) | |||
There was a problem hiding this comment.
Gate this as per @eparis suggestion and also remove the if clause below since we already log status updates in the controller
Decrease verbosity and reword 'Observed updated replication controller ...' now that the issue it was added for has been fixed.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kargakis, ncdc, wojtek-t
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
size/XS
|
@k8s-bot cvm gce e2e test this |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decrease verbosity and reword 'Observed updated replication controller
...' now that the issue it was added for has been fixed.
This was originally added to debug #31981, and it was fixed back in September 2016.
cc @gmarek @wojtek-t @Kargakis @eparis @smarterclayton