Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kubectl to use PropagationPolicy instead of OrphanDependents #46659

Closed
3 tasks
nikhiljindal opened this issue May 31, 2017 · 4 comments
Closed
3 tasks

Update kubectl to use PropagationPolicy instead of OrphanDependents #46659

nikhiljindal opened this issue May 31, 2017 · 4 comments
Assignees
@nikhiljindal
Labels
area/kubectl lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/cli Categorizes an issue or PR as relevant to SIG CLI.

Comments

@nikhiljindal
Copy link
Contributor

Forked from #46471 (comment) based on discussion with @caesarxuchao.

kubectl, today, uses DeleteOptions.OrphanDependents field to do cascading deletion.
We need to do the following to update kubectl to use PropagationPolicy instead.

  • In 1.7, update federation-apiserver to support PropagationPolicy
  • In 1.8, update kubectl to use PropagationPolicy instead of OrphanDependents.
  • In 1.9, we can then stop supporting OrphanDependents in kube-apiserver and federation-apiserver.
@nikhiljindal nikhiljindal added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. labels May 31, 2017
@nikhiljindal nikhiljindal self-assigned this May 31, 2017
@nikhiljindal nikhiljindal mentioned this issue May 31, 2017
Closed
@0xmichalis
Copy link
Contributor

cc: @mfojtik @tnozicka @fabianofranz

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 26, 2017
distorhead added a commit to werf/werf that referenced this issue Jan 15, 2018
@distorhead
(fix) Delete hooks job site-migrations ... hangs
43ebd9f 
Job deletion hanging on kubernetes 1.8, because job appeared in jobs list after successful deletion request.

* All related job's pods are deleted explicitly now.
* Job deletion request is now being done with parameter orphanDependents=false.

Also:
* According to the docs: https://kubernetes.io/docs/concepts/workloads/controllers/garbage-collection/,
  orphanDependents is deprecated, should be propagationPolicy=Orphan. But it does not work.
* Kubectl still use orphanDependents.: https://github.com/kubernetes/kubernetes/blob/master/pkg/kubectl/delete.go#L388
* kubernetes/kubernetes#46659
@distorhead distorhead mentioned this issue Jan 15, 2018
Merged
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 25, 2018
@nilebox nilebox mentioned this issue Feb 13, 2018
Closed
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikhiljindal nikhiljindal

Labels
area/kubectl lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/cli Categorizes an issue or PR as relevant to SIG CLI.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@0xmichalis @nikhiljindal @k8s-ci-robot @fejta-bot