Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump the gke-cert-controller wokers to match it's qps #47858

Merged
merged 1 commit into from Jun 21, 2017
Merged

bump the gke-cert-controller wokers to match it's qps #47858

merged 1 commit into from Jun 21, 2017

Conversation

mikedanese
Copy link
Member

@mikedanese mikedanese commented Jun 21, 2017 •
edited

This increases Issuance per second from 2.5 csrs to 5 csrs which is the theoretical limit with the current client side rate limiting.

Issue #47855

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 21, 2017
@mikedanese mikedanese assigned pipejakob and gmarek and unassigned pipejakob Jun 21, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jun 21, 2017
@mikedanese mikedanese added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jun 21, 2017
@mikedanese mikedanese added this to the v1.7 milestone Jun 21, 2017
gmarek
gmarek reviewed Jun 21, 2017
View reviewed changes
cmd/gke-certificates-controller/app/gke_certificates_controller.go
controller.Run(1, nil) // runs forever
return nil
controller.Run(5, nil) // runs forever
panic("unreachable")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you want this panic here:)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? it's supposed to be unreachable. Better then returning nil

@pipejakob
Copy link
Contributor

/lgtm

I'm not sure of the downside of the return nil vs. panic() when we expect the code to be unreachable, so I have no strong opinion on that. I guess if you comment out controller.Run(), whichever gives the clearer error message in the logs should be preferred.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikedanese, pipejakob

Associated issue: 47855

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 47851, 47824, 47858, 46099)

@k8s-github-robot k8s-github-robot merged commit aa1c8da into kubernetes:master Jun 21, 2017
@mikedanese mikedanese deleted the fix branch June 21, 2017 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmarek gmarek gmarek left review comments

Assignees

@pipejakob pipejakob

@gmarek gmarek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mikedanese @pipejakob @k8s-github-robot @gmarek @k8s-ci-robot