-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump the gke-cert-controller wokers to match it's qps #47858
Conversation
controller.Run(1, nil) // runs forever | ||
return nil | ||
controller.Run(5, nil) // runs forever | ||
panic("unreachable") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you want this panic here:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? it's supposed to be unreachable. Better then returning nil
/lgtm I'm not sure of the downside of the |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikedanese, pipejakob Associated issue: 47855 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Automatic merge from submit-queue (batch tested with PRs 47851, 47824, 47858, 46099) |
This increases Issuance per second from 2.5 csrs to 5 csrs which is the theoretical limit with the current client side rate limiting.
Issue #47855