Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump the gke-cert-controller wokers to match it's qps #47858

Merged
merged 1 commit into from Jun 21, 2017
Merged

bump the gke-cert-controller wokers to match it's qps #47858

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/gke-certificates-controller/app/gke_certificates_controller.go
View file
Open in desktop
Expand Up @@ -87,6 +87,6 @@ func Run(s *GKECertificatesController) error {
}

sharedInformers.Start(nil)
controller.Run(1, nil) // runs forever
return nil
controller.Run(5, nil) // runs forever
panic("unreachable")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you want this panic here:)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? it's supposed to be unreachable. Better then returning nil

}