include object fieldpath in event key #47973
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
looking |
k8s-github-robot
added
size/XS
|
Do we have a reproducer that we can point to to say that this fully resolves #47692 ? |
| @@ -49,6 +49,7 @@ func getEventKey(event *v1.Event) string { | |||
| event.InvolvedObject.Kind, | |||
| event.InvolvedObject.Namespace, | |||
| event.InvolvedObject.Name, | |||
| event.InvolvedObject.FieldPath, | |||
There was a problem hiding this comment.
this makes sense. aggregator bumped the count since the message didn't vary?
|
@pmorie yes, there is a reproducer pod in the issue that works every time. I'm writing a test case now. |
sjenning
force-pushed
the
include-obj-fieldpath-event-key
branch
from
b1601a7
to
fbcb056
Compare
|
test case added. ready for review/approval. |
k8s-github-robot
added
size/S
|
/test pull-kubernetes-e2e-gce-etcd3 |
|
/assign |
k8s-ci-robot
added
release-note-none
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, eparis, sjenning Associated issue: 47692 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, eparis, sjenning Associated issue: 47692 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
2 similar comments
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, eparis, sjenning Associated issue: 47692 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, eparis, sjenning Associated issue: 47692 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
dchen1107
added
cherry-pick-approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dchen1107, deads2k, eparis, sjenning Associated issue: 47692 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
@sjenning could you please create a cherrypick pr for this. Thanks! |
|
@dchen1107 I can. Not sure we need to though. #47462 that exposed this bug by removing container-specific information from the event message was not cherry picked to 1.6. Do you still want me to cherry-pick this? |
|
Automatic merge from submit-queue |
|
@sjenning I think she means a pick to 1.7 since it already forked and master is now 1.8. |
|
@eparis ah yes, that makes more sense. Didn't realize 1.7 had been forked already. |
…ey-1.7 Automatic merge from submit-queue include object fieldpath in event key 1.7 cherry-pick for #47973 @eparis @dchen1107 @derekwaynecarr @pmorie @deads2k
|
Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
Fixes #47692
#47462 exposed a bug where
getEventKey()only keys on event fields that are common at the pod level. Events generated by different containers in the same pod will yield identical event keys. This results in events with the same message from different containers in a pod being aggregated in error.This wasn't a problem before as the event message contained container specific information and thus didn't produce the same event key.
@derekwaynecarr @dhilipkumars @dchen1107