Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align GroupName in pkg/apis #48527

Closed
k82cn opened this issue Jul 6, 2017 · 9 comments
Closed

Align GroupName in pkg/apis #48527

k82cn opened this issue Jul 6, 2017 · 9 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@k82cn
Copy link
Member

k82cn commented Jul 6, 2017

Is this a BUG REPORT or FEATURE REQUEST?:
enhancement/cleanup

/kind bug
/sig api-machinery

What happened:
In pkg/apis, there're 3 types of GroupName: xxx, xxx.k8s.io, xxx.kubernetes.io. Should we align them to xxx.k8s.io?

@kubernetes/sig-api-machinery-misc

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jul 6, 2017
@sttts
Copy link
Contributor

sttts commented Jul 6, 2017

These determine the HTTP path. So we cannot fix our broken naming easily.

@k82cn
Copy link
Member Author

k82cn commented Jul 6, 2017

yes. Agree that's complex; I try to create a PR today; but I found lots of code are using text, e.g. "apps".

@sttts
Copy link
Contributor

sttts commented Jul 6, 2017

It break the api, that's the bigger problem.

@deads2k
Copy link
Contributor

deads2k commented Jul 6, 2017

I think we should align them (we chose k8s.io) and it can be done by double registering for some period of time.

@k82cn
Copy link
Member Author

k82cn commented Jul 7, 2017

I think this's not urgent issue. If we agree to do that, I may contribute after 1.8.

cc/ @smarterclayton

@lavalamp
Copy link
Member

We cannot fix this for existing APIs easily. We mandate *.k8s.io for new APIs.

@lavalamp lavalamp added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Jul 13, 2017
@k82cn
Copy link
Member Author

k82cn commented Jul 15, 2017 via email

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 31, 2017
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 30, 2018
@k82cn k82cn closed this as completed Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Development

No branches or pull requests

6 participants