New API group for Events. #49112

gmarek · 2017-07-18T11:39:59Z

Add events.k8s.io api group with v1beta1 API containing redesigned Event type.

gmarek · 2017-07-18T17:26:53Z

@caesarxuchao - can you please finish this PR, but adding stuff that's needed for update-all.sh to successfully run? If not you can someone from @kubernetes/sig-api-machinery-api-reviews do that?

As I don't have any idea what needs to be done and it's not documented anywhere I'll need to fall back to just modifying Event type in place in v1.Core group.

caesarxuchao · 2017-07-18T22:41:13Z

Have you taken a look at the doc updates in kubernetes/community#788?

gmarek · 2017-07-19T04:40:16Z

No - I've found only last updates from few months back, which weren't merged.

timothysc · 2017-07-19T16:09:30Z

pkg/apis/events/types.go

+// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
+
+// Event is a report of an event somewhere in the cluster. It generally denotes some state change in the system.
+type EventTwo struct {


please don't call this EventTwo

Sorry - that's a placeholder. Current API machinery doesn't allow creating type Event inside group events, because it tries to be smart and creates a type events (plural for type Event) and we get name collision. Is it likely to get fixed in 1.8 timeframe? @kubernetes/sig-api-machinery-bugs @sttts

@gmarek do you have a gist with the conflict in code?

is it the type in the client?

Oh sorry - I meant to cc @deads2k as he already knows the issue.

@sttts - I can generate it easily enough. I'll do this tomorrow.

@gmarek see #49224

I tried patching it, but it didn't help - updated this PR with the result.

@sttts gist for you:

pkg/client/clientset_generated/internalclientset/typed/events/internalversion/event.go:48: events redeclared in this block

Once here:

import ( v1 "k8s.io/apimachinery/pkg/apis/meta/v1" types "k8s.io/apimachinery/pkg/types" watch "k8s.io/apimachinery/pkg/watch" rest "k8s.io/client-go/rest" events "k8s.io/kubernetes/pkg/apis/events" scheme "k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset/scheme" )

and once here:

// events implements EventInterface type events struct { client rest.Interface ns string }

Oh, sorry - I didn't notice that I need to add overrides. Trying it now.

Nope, still doesn't work.

timothysc · 2017-07-19T16:10:15Z

pkg/apis/events/types.go

+	// Required. Time when this Event was first observed.
+	EventTime metav1.MicroTime
+	// Optional. Data about the Event series this event represents or nil if it's a singleton Event.
+	Series *EventSeries


@kensimon speak now or forever hold your peace.

thockin

Approving as-is, but a few nits

thockin · 2017-11-22T21:26:28Z

pkg/apis/core/field_constants.go

@@ -25,8 +25,8 @@ const (
 	PodStatusField         = "status.phase"
 	SecretTypeField        = "type"

-	EventReasonField                  = "reason"
-	EventSourceField                  = "source"
+	EventReasonField                  = "action"


I have no idea what these are for - nothing seems to use them in the codebase..

thockin · 2017-11-22T21:33:59Z

staging/src/k8s.io/api/events/v1beta1/types.go

+
+	// Name of the controller that emitted this Event, e.g. `kubernetes.io/kubelet`.
+	// +optional
+	ReportingController string `json:"reportingController,omitempty" protobuf:"bytes,4,opt,name=reportingController"`


All optional fields should be pointers

thockin · 2017-11-22T21:40:07Z

/lgtm
/approve

k8s-github-robot · 2017-11-22T21:40:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caesarxuchao, gmarek, thockin

Associated issue: 383

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

~~api/OWNERS~~ [thockin]
~~cmd/kube-apiserver/OWNERS~~ [caesarxuchao,thockin]
~~cmd/kube-controller-manager/OWNERS~~ [thockin]
~~docs/api-reference/OWNERS~~ [thockin]
~~hack/OWNERS~~ [gmarek,thockin]
~~pkg/OWNERS~~ [thockin]
~~staging/OWNERS~~ [thockin]
~~test/OWNERS~~ [gmarek,thockin]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

k8s-github-robot · 2017-11-23T00:34:00Z

[MILESTONENOTIFIER] Milestone Pull Request Current

@caesarxuchao @derekwaynecarr @gmarek @smarterclayton @sttts @thockin

Note: This pull request is marked as priority/critical-urgent, and must be updated every 1 day during code freeze.

Example update:

ACK.  In progress
ETA: DD/MM/YYYY
Risks: Complicated fix required

Pull Request Labels

sig/api-machinery: Pull Request will be escalated to these SIGs if needed.
priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
kind/feature: New functionality.

Help

fejta-bot · 2017-11-23T03:55:17Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

k8s-ci-robot · 2017-11-23T04:25:14Z

@gmarek: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kubernetes-cross	`ef6f0b8`	link	`/test pull-kubernetes-cross`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-github-robot · 2017-11-23T05:32:15Z

/test all [submit-queue is verifying that this PR is safe to merge]

k8s-github-robot · 2017-11-23T05:48:40Z

Automatic merge from submit-queue (batch tested with PRs 55952, 49112, 55450, 56178, 56151). If you want to cherry-pick this change to another branch, please follow the instructions here.

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 18, 2017

k8s-github-robot assigned derekwaynecarr and timothysc Jul 18, 2017

k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/new-api size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 18, 2017

gmarek force-pushed the eventAPI branch 3 times, most recently from f5fc4e3 to 5ddde7d Compare July 18, 2017 17:24

k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 18, 2017

k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Jul 18, 2017

gmarek force-pushed the eventAPI branch from 5ddde7d to 0e58665 Compare July 19, 2017 10:23

gmarek assigned gmarek and unassigned timothysc and derekwaynecarr Jul 19, 2017

gmarek force-pushed the eventAPI branch 3 times, most recently from bd3bba3 to f2bdfe3 Compare July 19, 2017 15:27

timothysc reviewed Jul 19, 2017

View reviewed changes

gmarek force-pushed the eventAPI branch 5 times, most recently from 9e212e3 to 4f385da Compare July 20, 2017 13:46

thockin reviewed Nov 22, 2017

View reviewed changes

k8s-ci-robot assigned thockin Nov 22, 2017

k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2017

thockin added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Nov 22, 2017

k8s-github-robot added milestone/needs-attention milestone/removed and removed milestone/incomplete-labels milestone/needs-attention labels Nov 22, 2017

k8s-github-robot removed this from the v1.9 milestone Nov 22, 2017

enisoc added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Nov 23, 2017

enisoc added this to the v1.9 milestone Nov 23, 2017

enisoc removed the milestone/removed label Nov 23, 2017

k8s-github-robot added the milestone/needs-attention label Nov 23, 2017

enisoc added the status/in-progress label Nov 23, 2017

k8s-github-robot removed the milestone/needs-attention label Nov 23, 2017

k8s-github-robot merged commit 60c2090 into kubernetes:master Nov 23, 2017

yastij mentioned this pull request Nov 28, 2017

start migrating controllers to use the new Event API group #56514

Open

liggitt mentioned this pull request Dec 21, 2017

--etcd-servers-overrides in apiserver do not work #57440

Closed

yastij mentioned this pull request Jun 25, 2019

use new EventRecorder to emit v1beta1 Events kubernetes-sigs/cluster-api#1023

Closed

yastij mentioned this pull request Sep 23, 2019

Next steps after Events API v1beta1: migrate all components; event style guide; pipeline for persistent event storage #76674

Open

logicalhan mentioned this pull request Mar 19, 2020

Cannot set the eventTime field when creating/updating Events #89062

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New API group for Events. #49112

New API group for Events. #49112

gmarek commented Jul 18, 2017 •

edited

gmarek commented Jul 18, 2017

caesarxuchao commented Jul 18, 2017

gmarek commented Jul 19, 2017

timothysc Jul 19, 2017

gmarek Jul 19, 2017

sttts Jul 19, 2017

sttts Jul 19, 2017

gmarek Jul 19, 2017

deads2k Jul 19, 2017

gmarek Jul 20, 2017 •

edited

gmarek Jul 20, 2017

gmarek Jul 20, 2017

timothysc Jul 19, 2017

thockin left a comment

thockin Nov 22, 2017

thockin Nov 22, 2017

thockin commented Nov 22, 2017

k8s-github-robot commented Nov 22, 2017

k8s-github-robot commented Nov 23, 2017

fejta-bot commented Nov 23, 2017

k8s-ci-robot commented Nov 23, 2017 •

edited

k8s-github-robot commented Nov 23, 2017

k8s-github-robot commented Nov 23, 2017

New API group for Events. #49112

New API group for Events. #49112

Conversation

gmarek commented Jul 18, 2017 • edited

gmarek commented Jul 18, 2017

caesarxuchao commented Jul 18, 2017

gmarek commented Jul 19, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gmarek Jul 20, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thockin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thockin commented Nov 22, 2017

k8s-github-robot commented Nov 22, 2017

k8s-github-robot commented Nov 23, 2017

fejta-bot commented Nov 23, 2017

k8s-ci-robot commented Nov 23, 2017 • edited

k8s-github-robot commented Nov 23, 2017

k8s-github-robot commented Nov 23, 2017

gmarek commented Jul 18, 2017 •

edited

gmarek Jul 20, 2017 •

edited

k8s-ci-robot commented Nov 23, 2017 •

edited