Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic client does not support subresources #49588

Closed
crimsonfaith91 opened this issue Jul 25, 2017 · 5 comments · Fixed by #56717
Closed

Dynamic client does not support subresources #49588

crimsonfaith91 opened this issue Jul 25, 2017 · 5 comments · Fixed by #56717
Assignees
@roycaihw
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@crimsonfaith91
Copy link
Contributor

crimsonfaith91 commented Jul 25, 2017 •
edited

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:
/kind feature

What happened: Existing dynamic client library does not support subresources.

What you expected to happen: The library should support the subresources to facilitate e2e testing.

How to reproduce it (as minimally and precisely as possible):
N/A

Anything else we need to know?:
N/A

Environment: N/A

  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration**:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:

/sig api-machinery
/cc @lavalamp
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jul 25, 2017
@crimsonfaith91
Copy link
Contributor Author

@enisoc

@mml
Copy link
Contributor

mml commented Jul 31, 2017

@mbohlool can you take a look?

@mbohlool
Copy link
Contributor

mbohlool commented Aug 8, 2017

@caesarxuchao I guess this is client-go. Can you take care of this? I can also look if you want me to.

@mbohlool mbohlool removed their assignment Aug 16, 2017
@caesarxuchao
Copy link
Member

@roycaihw feel free to have a try.

@roycaihw roycaihw mentioned this issue Dec 1, 2017
Merged
k8s-github-robot pushed a commit that referenced this issue Feb 14, 2018
Merge pull request #56717 from roycaihw/dynamic_subresource
f33e0b3 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Dynamic client supports subresources

**What this PR does / why we need it**:
Allows `resource.name` to be a subresource which contains `"/"` in https://github.com/kubernetes/kubernetes/blob/db2977fb11fee4c2d3a362d003c76903ea50633c/staging/src/k8s.io/client-go/dynamic/client.go#L143

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #49588 

**Special notes for your reviewer**:
The change is backward compatible. 

**Release note**:

```release-note
NONE
```

/sig api-machinery
@enisoc
Copy link
Member

enisoc commented Feb 14, 2018

Woohoo! Thanks @roycaihw!

@roycaihw roycaihw mentioned this issue May 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roycaihw roycaihw

Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dynamic client supports subresources roycaihw/kubernetes
7 participants
@mml @mbohlool @caesarxuchao @roycaihw @enisoc @crimsonfaith91 @k8s-ci-robot