Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip WaitForAttachAndMount for terminated pods in syncPod #49724

Merged
merged 1 commit into from
Aug 1, 2017
Merged

skip WaitForAttachAndMount for terminated pods in syncPod #49724

merged 1 commit into from
Aug 1, 2017

Conversation

sjenning
Copy link
Contributor

Fixes #49663

I tried to tread lightly with a small localized change because this needs to be picked to 1.7 and 1.6 as well.

I suspect this has been as issue since we started unmounting volumes on pod termination #37228

xref openshift/origin#14383

@derekwaynecarr @eparis @smarterclayton @saad-ali @jwforres

/release-note-none

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 27, 2017
@derekwaynecarr
Copy link
Member

this is the same gating logic that we use for pod level cgroup creation and destruction, so it appears safe to me. will wait for bots to report green.

@derekwaynecarr derekwaynecarr self-assigned this Jul 27, 2017
@derekwaynecarr
Copy link
Member

not for this pr, but a good future gating test would be to see if we get events about a pod from the node after its death. i am not sure how long it should wait, but maybe a node e2e could let us experiement on it in future.

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Jul 27, 2017
@sjenning
Copy link
Contributor Author

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jul 27, 2017
@derekwaynecarr
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, sjenning

Associated issue: 49663

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2017
@sjenning
Copy link
Contributor Author

Can I get a cherry-pick-candidate on this?

@sjenning sjenning mentioned this pull request Jul 28, 2017
Merged
@fejta-bot
Copy link

/retest
Automatic flake /retester. Please send feedback to @fejta

3 similar comments
@fejta-bot
Copy link

/retest
Automatic flake /retester. Please send feedback to @fejta

@fejta-bot
Copy link

/retest
Automatic flake /retester. Please send feedback to @fejta

@fejta-bot
Copy link

/retest
Automatic flake /retester. Please send feedback to @fejta

@fejta-bot
Copy link

/retest
The automatic /retester retries failing jobs on approved PRs. Please send feedback to @fejta
Full #49724 test result history.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

8 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

4 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 49284, 49555, 47639, 49526, 49724)

@k8s-github-robot k8s-github-robot merged commit b20beaa into kubernetes:master Aug 1, 2017
openshift-merge-robot added a commit to openshift/origin that referenced this pull request Aug 2, 2017
@openshift-merge-robot
Merge pull request #15533 from sjenning/pick-49724
b4901f6 
Automatic merge from submit-queue

UPSTREAM: 49724: skip WaitForAttachAndMount for terminated pods in syncPod

Fixes #14383

xref kubernetes/kubernetes#49724

@derekwaynecarr @eparis @smarterclayton @jwforres
@sjenning sjenning deleted the skip-sync-mount-terminated-pods branch August 16, 2017 02:16
@j4mcs j4mcs mentioned this pull request May 4, 2020
Closed
@jingxu97 jingxu97 mentioned this pull request Mar 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sjenning @derekwaynecarr @k8s-github-robot @fejta-bot @k8s-ci-robot