Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear alpha MountPropagation fields. #51893

Merged
merged 1 commit into from Sep 5, 2017
Merged

Clear alpha MountPropagation fields. #51893

merged 1 commit into from Sep 5, 2017

Conversation

jsafrane
Copy link
Member

@jsafrane jsafrane commented Sep 4, 2017

This is leftover from #50924, mount propagation introduced a new field that needs to be cleared.

Which issue this PR fixes
fixes #51738

Release note:

NONE

@k8s-mirror-api-machinery-pr-reviews
/assign @liggitt

@jsafrane
Clear alpha MountPropagation fields.
876109a 
According to api_changes.md, alpha fields must be cleared when corresponding
feature is disabled.
@jsafrane jsafrane added this to the v1.8 milestone Sep 4, 2017
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 4, 2017
@k8s-github-robot k8s-github-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 4, 2017
@jsafrane jsafrane force-pushed the clear-alpha-mount-propagation branch from 122d0b6 to 305f007 Compare September 4, 2017 10:50
liggitt
liggitt reviewed Sep 4, 2017
View reviewed changes
pkg/api/pod/util.go
@@ -243,4 +243,17 @@ func DropDisabledAlphaFields(podSpec *api.PodSpec) {
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InitContainers as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, fixed

@jsafrane jsafrane force-pushed the clear-alpha-mount-propagation branch 2 times, most recently from dc33375 to 876109a Compare September 4, 2017 14:17
@liggitt
Copy link
Member

liggitt commented Sep 4, 2017 

I0904 11:01:51.316] Verifying hack/make-rules/../../hack/verify-bazel.sh
I0904 11:02:14.572] --- /go/src/k8s.io/kubernetes/pkg/registry/settings/podpreset/BUILD	2017-09-04 10:55:50.031990023 +0000
I0904 11:02:14.572] +++ /tmp/BUILD143234423	2017-09-04 11:02:02.968193641 +0000
I0904 11:02:14.572] @@ -14,6 +14,7 @@
I0904 11:02:14.572]      ],
I0904 11:02:14.573]      deps = [
I0904 11:02:14.573]          "//pkg/api:go_default_library",
I0904 11:02:14.573] +        "//pkg/api/pod:go_default_library",
I0904 11:02:14.573]          "//pkg/apis/settings:go_default_library",
I0904 11:02:14.573]          "//pkg/apis/settings/validation:go_default_library",
I0904 11:02:14.573]          "//vendor/k8s.io/apimachinery/pkg/apis/meta/internalversion:go_default_library",
I0904 11:02:14.573] 
I0904 11:02:14.574] 
I0904 11:02:14.574] Run ./hack/update-bazel.sh
I0904 11:02:14.631] FAILED   hack/make-rules/../../hack/verify-bazel.sh	23s

@liggitt
Copy link
Member

liggitt commented Sep 4, 2017

oh, nevermind, that was a stale test result

@liggitt
Copy link
Member

liggitt commented Sep 4, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 4, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jsafrane, liggitt
We suggest the following additional approver: lavalamp

Assign the PR to them by writing /assign @lavalamp in a comment when ready.

Associated issue: 50924

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@jsafrane
Copy link
Member Author

jsafrane commented Sep 4, 2017

/assign @wojtek-t @smarterclayton for approval

@liggitt liggitt added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Sep 5, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@liggitt
Copy link
Member

liggitt commented Sep 5, 2017

/test pull-kubernetes-node-e2e
gcloud update failure

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 51180, 51893)

@k8s-github-robot k8s-github-robot merged commit 58fe20f into kubernetes:master Sep 5, 2017
@k8s-ci-robot
Copy link
Contributor

@jsafrane: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws 876109a link /test pull-kubernetes-e2e-kops-aws
pull-kubernetes-e2e-gce-etcd3 876109a link /test pull-kubernetes-e2e-gce-etcd3

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

Assignees

@liggitt liggitt

@smarterclayton smarterclayton

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

Pod MountPropagation needs clearing when disabled
6 participants
@jsafrane @liggitt @k8s-github-robot @k8s-ci-robot @smarterclayton @wojtek-t