Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should validate ipvs proxy options #53852

Closed
m1093782566 opened this issue Oct 13, 2017 · 1 comment · Fixed by #53780
Closed

Should validate ipvs proxy options #53852

m1093782566 opened this issue Oct 13, 2017 · 1 comment · Fixed by #53780
Assignees
@m1093782566
Labels
area/kube-proxy kind/bug Categorizes issue or PR as related to a bug. sig/network Categorizes an issue or PR as relevant to SIG Network.

Comments

@m1093782566
Copy link
Contributor

m1093782566 commented Oct 13, 2017 •
edited

Is this a BUG REPORT or FEATURE REQUEST?:

/kind bug

What happened:

Some kube-proxy options are not validated.

What you expected to happen:

We should validate these options before running.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration**:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:

/sig network

/area kube-proxy
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. area/kube-proxy kind/bug Categorizes issue or PR as related to a bug. labels Oct 13, 2017
@frodenas frodenas mentioned this issue Oct 13, 2017
Closed
@m1093782566 m1093782566 mentioned this issue Oct 14, 2017
Merged
@m1093782566
Copy link
Contributor Author

/assign

k8s-github-robot pushed a commit that referenced this issue Nov 15, 2017
Merge pull request #53780 from m1093782566/validate-ipvs
5e17893 
Automatic merge from submit-queue (batch tested with PRs 53780, 55663, 55321, 52421, 55659). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Validate kube-proxy options

**What this PR does / why we need it**:

Validate ipvs proxy options

**Which issue this PR fixes** : fixes #53852

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m1093782566 m1093782566

Labels
area/kube-proxy kind/bug Categorizes issue or PR as related to a bug. sig/network Categorizes an issue or PR as relevant to SIG Network.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate kube-proxy options m1093782566/kubernetes
Validate kube-proxy IPVS configuration
2 participants
@m1093782566 @k8s-ci-robot