Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate kube-proxy IPVS configuration #53901

Closed
wants to merge 1 commit into from
Closed

Validate kube-proxy IPVS configuration #53901

wants to merge 1 commit into from

Conversation

frodenas
Copy link
Contributor

@frodenas frodenas commented Oct 13, 2017 •
edited

What this PR does / why we need it:

kube-proxy IPVS configuration was not validated when using a config file. This PR adds validation for IPVS configuration.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #53852

Special notes for your reviewer:

Release note:

IPVS configuration is now validated before starting `kube-proxy`

@frodenas
Validate kube-proxy IPVS configuration
82296bd 
Signed-off-by: Ferran Rodenas <frodenas@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 13, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @frodenas. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: frodenas
We suggest the following additional approver: dchen1107

Assign the PR to them by writing /assign @dchen1107 in a comment when ready.

Associated issue: 53852

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Oct 13, 2017
@frodenas
Copy link
Contributor Author

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 13, 2017
@k8s-github-robot k8s-github-robot removed the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Oct 13, 2017
@xiangpengzhao
Copy link
Contributor

/cc @m1093782566
/ok-to-test
BTW, I don't think this PR needs a release note :)

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 13, 2017
@m1093782566
Copy link
Contributor

a duplication of #53780?

@m1093782566
Copy link
Contributor

Sorry my initial PR didn't point to my issue at first. However, I think discussing below the issue may help avoid PR duplication? FYI:)

m1093782566
m1093782566 reviewed Oct 14, 2017
View reviewed changes
cmd/kube-proxy/app/validation.go
@@ -38,6 +38,7 @@ func Validate(config *componentconfig.KubeProxyConfiguration) field.ErrorList {
allErrs = append(allErrs, validateKubeProxyConntrackConfiguration(config.Conntrack, newPath.Child("KubeProxyConntrackConfiguration"))...)
allErrs = append(allErrs, validateProxyMode(config.Mode, newPath.Child("Mode"))...)
allErrs = append(allErrs, validateClientConnectionConfiguration(config.ClientConnection, newPath.Child("ClientConnection"))...)
allErrs = append(allErrs, validateKubeProxyIPVSConfiguration(config.IPVS, newPath.Child("KubeProxyIPVSConfiguration"))...)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, It's almost a duplication of #53780?

@m1093782566
Copy link
Contributor

m1093782566 commented Oct 14, 2017 •
edited

Thanks @xiangpengzhao , +1

BTW, I am applying for pkg/proxy/OWNERS reviewer(#53864), possibly the k8s-robot will assign more IPVS proxier stuff related PRs to me in the future.

@xiangpengzhao
Copy link
Contributor

@m1093782566 awesome!

@frodenas
Copy link
Contributor Author

@m1093782566 yep, this is a duplicate then. I checked the issue for PR and assignment references before working on my PR. I see you added them now, good. Closing this issue.

@frodenas frodenas closed this Oct 14, 2017
@m1093782566
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m1093782566 m1093782566 m1093782566 left review comments

Assignees

@dchen1107 dchen1107

@therc therc

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should validate ipvs proxy options
7 participants
@frodenas @k8s-ci-robot @k8s-github-robot @xiangpengzhao @m1093782566 @dchen1107 @therc