-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Support disk quota for docker runtime #54384
Comments
/sig node |
/kind feature |
Any updates? |
We would be interested as well ! Service provider with little to no control of what data is stored where by our customers. This would be a nice workaround against disk resource exhaustion of nodes whenever the customer craps outside its persistent volumes. |
Just a notification about |
Before we add support for configuring
Maybe @kubernetes/sig-storage-feature-requests @jingxu97 @vishh can give some advises. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
@andyxning Kubernetes 1.8 add |
In my opinion, I think Since kubelet would like to evict pod if the ephemeral-storage limit exceeded, and adding Currently, I think |
I do not think we need to pass |
@Colstuwjx @NickrenREN Others resource limitations like |
@BSWANG I agree kubernetes acts differently for container BTW: referring to the docker doc : https://docs.docker.com/engine/reference/commandline/run/#set-storage-driver-options-per-container, there are still some limits for |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
The problem with ephemeral storage is even worse than the du latency; it's possible for a pod (attached) to create a file and delete it, but keep the file descriptor around. Without quota support, any pod or container within it can use as much ephemeral storage as it wants and never get caught doing so. File descriptors can get passed around in various ways (e. g. over a UNIX domain socket), so containers sharing an emptydir volume but otherwise no parent/child process hierarchy can still share in this; the disk space won't go away until everything having the file open does. Remove the |
@RobertKrawitz it looks like jingxu97 was working on "Local Ephemeral Storage Capacity Isolation" this but idk the current status kubernetes/enhancements#361 , you may wish to contact her |
/remove-lifecycle stale |
Any support on this? I think this feature would be definitely useful. |
In progress (not this issue per se); see #66928 |
Hi @RobertKrawitz Thanks for the PR , I notice that PR will implement a quota enforcement right? |
I have been checked the document, and I think, for now, it's focusing on monitoring, not enforcement of quota limit. From my sight, there is some considerations:
Thanks @RobertKrawitz great job! |
If I understand correctly, this should be solved by kubernetes/enhancements#1029. Currently, it is an alpha-level feature. I asked to promote it to beta and after some discussions, we think there are several things to do before promoting it to beta. But for this issue, I think we can close it as resolved. And it should be tracked in kubernetes/enhancements#1029. See kubernetes/enhancements#1029 (comment) for more details.
|
/triage accepted |
This issue has not been updated in over 1 year, and should be re-triaged. You can:
For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/ /remove-triage accepted |
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
As docker already support
docker run --storage-opt size=1G xxx
such way to limit container disk usage, it would be better if k8s introduced this feature.On the other hand, it also would be OK if k8s support pass
--storage-opt
incontainers
spec.Thanks.
The text was updated successfully, but these errors were encountered: