Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop running unit tests outside of Bazel. #55279

Merged
merged 1 commit into from
Nov 9, 2017
Merged

Stop running unit tests outside of Bazel. #55279

merged 1 commit into from
Nov 9, 2017

Conversation

spxtr
Copy link
Contributor

@spxtr spxtr commented Nov 8, 2017 •
edited

We tried this a while ago, but had to revert because Bazel did not have
race detection. Now it does.

Previous issue: #40602 and #52443

Relevant parties: @ixdy @mikedanese @smarterclayton @deads2k @liggitt

/sig testing

NONE

@spxtr
Stop running unit tests outside of Bazel.
e72a166 
We tried this a while ago, but had to revert because Bazel did not have
race detection. Now it does.
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 8, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2017
@BenTheElder
Copy link
Member

/retest

@ixdy
Copy link
Member

ixdy commented Nov 8, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2017
@smarterclayton
Copy link
Contributor

lgtm as well

@mikedanese
Copy link
Member

/lgtm

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ixdy, mikedanese, spxtr

Associated issue: 40602

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@deads2k
Copy link
Contributor

deads2k commented Nov 8, 2017

Thanks for the heads up.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 53747, 54528, 55279, 55251, 55311). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit d1ba544 into kubernetes:master Nov 9, 2017
@spxtr spxtr deleted the ImperialToSI branch November 9, 2017 06:38
@BenTheElder
Copy link
Member

FYI @spiffxp

This was referenced Nov 22, 2017
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rmmh rmmh

@fejta fejta

@mikedanese mikedanese

@ixdy ixdy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@spxtr @BenTheElder @ixdy @smarterclayton @mikedanese @k8s-github-robot @deads2k @rmmh @fejta @k8s-ci-robot