Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bazel jobs to release-master-blocking #5654

Merged
merged 1 commit into from
Nov 22, 2017

Conversation

BenTheElder
Copy link
Member

xref: #5558 (comment)

/area jobs

@k8s-ci-robot k8s-ci-robot added area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 22, 2017
@BenTheElder BenTheElder requested review from spiffxp and removed request for michelle192837 November 22, 2017 20:07
@BenTheElder
Copy link
Member Author

Anything failing in bazel-test would have been failing in unit until kubernetes/kubernetes#55279
We need to be blocking on these to match the last release. (since if bazel-build is failing bazel-test won't work anyhow..)

@spiffxp
Copy link
Member

spiffxp commented Nov 22, 2017

/lgtm
this has been a blocking presubmit for a while, and meets the rough criteria laid out in kubernetes/sig-release#24

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, spiffxp

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:
  • OWNERS [BenTheElder,spiffxp]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member Author

BenTheElder commented Nov 22, 2017

Note that bazel-test is failing currently on 1.9 due to a broken unit tests and due to k/k integration tests generally being flaky / bad, but we should fix these cases instead of throwing out the whole job.
Edit: and until the PR mentioned above these would have failed in *-kubernetes-unit instead.

@k8s-ci-robot k8s-ci-robot merged commit 1319b18 into kubernetes:master Nov 22, 2017
@BenTheElder BenTheElder deleted the block-on-bazel branch November 22, 2017 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants