Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure disk: storage class should support the sku if the storage accout support it #55774

Closed
weherdh opened this issue Nov 15, 2017 · 5 comments · Fixed by #55931
Closed

Azure disk: storage class should support the sku if the storage accout support it #55774

weherdh opened this issue Nov 15, 2017 · 5 comments · Fixed by #55931
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@weherdh
Copy link

weherdh commented Nov 15, 2017

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

/kind feature

What happened:
Now for storage class only support skuName with Premium_LRS and Standard_LRS
Met error if the storage account was created with other sku. But actually it can work well without setting it

What you expected to happen:
skuName should support others if the storage account support it

How to reproduce it (as minimally and precisely as possible):
Create a storage account which is using Standard_RAGRS sku. Create storage class as below:

apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  name: scazure
parameters:
  location: eastus
  skuName: Standard_RAGRS
  storageAccount: storage
provisioner: kubernetes.io/azure-disk

Create pvc as below

apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  annotations:
    volume.beta.kubernetes.io/storage-class: scazure
  name: azpvc
spec:
  accessModes:
  - ReadWriteOnce
  resources:
    requests:
      storage: 1Gi

PVC would never bind with below error:
Failed to provision volume with StorageClass "scazure": azureDisk - Standard_RAGRS is not supported sku/storageaccounttype. Supported values are [Premium_LRS Standard_LRS]

But if I remove the skuName parameter, the pvc could be bound

apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  name: scazure
parameters:
  location: eastus
  storageAccount: storage
provisioner: kubernetes.io/azure-disk

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version):
    Client Version: version.Info{Major:"1", Minor:"7", GitVersion:"v1.7.6+a08f5eeb62", GitCommit:"c84beff", GitTreeState:"clean", BuildDate:"2017-11-12T02:22:57Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}
    Server Version: version.Info{Major:"1", Minor:"7", GitVersion:"v1.7.6+a08f5eeb62", GitCommit:"c84beff", GitTreeState:"clean", BuildDate:"2017-11-12T02:22:57Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}

  • Cloud provider or hardware configuration:

  • OS (e.g. from /etc/os-release): RHEL7

  • Install tools: ansible

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 15, 2017
@weherdh
Copy link
Author

weherdh commented Nov 15, 2017

/assign andyzhangx

@k8s-github-robot k8s-github-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Nov 15, 2017
@weherdh
Copy link
Author

weherdh commented Nov 15, 2017

/sig azure

@k8s-github-robot k8s-github-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Nov 15, 2017
@andyzhangx
Copy link
Member

thanks, it's a requirement, we should support Standard_LRS, Standard_ZRS, Standard_GRS, Standard_RGRS, while for premium, it only support Premium_LRS

@andyzhangx
Copy link
Member

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 17, 2017
@andyzhangx
Copy link
Member

Standard_ZRS, Premium_GRS are not supported for azure disk now

k8s-github-robot pushed a commit that referenced this issue Nov 20, 2017
Automatic merge from submit-queue (batch tested with PRs 55963, 55790, 55670, 55931). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

add GRS, RAGRS storage account type support for azure disk

**What this PR does / why we need it**:
add Standard_GRS, Standard_RAGRS storage account type support for azure disk, and Standard_ZRS, Premium_GRS are not supported for azure disk now

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #55774

**Special notes for your reviewer**:

**Release note**:

```
add Standard_GRS, Standard_RAGRS support for azure disk
```
/sig azure
@rootfs @brendanburns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants