Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LimitRange can block pod termination #57201

Closed
derekwaynecarr opened this issue Dec 14, 2017 · 2 comments
Closed

LimitRange can block pod termination #57201

derekwaynecarr opened this issue Dec 14, 2017 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@derekwaynecarr
Copy link
Member

Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug

What happened:
https://bugzilla.redhat.com/show_bug.cgi?id=1509309

A LimitRange added to a namespace after it has pods can prevent terminating pods from being deleted if they do not conform to the min/max criteria.

What you expected to happen:
LimitRange should ignore pods that are marked for deletion as they really cannot change their resource requirements.
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 14, 2017
@derekwaynecarr derekwaynecarr mentioned this issue Dec 14, 2017
Merged
@k8s-github-robot k8s-github-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Dec 14, 2017
@derekwaynecarr
Copy link
Member Author

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Dec 14, 2017
@k8s-github-robot k8s-github-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Dec 14, 2017
@jennybuckley
Copy link

cc @cheftako

k8s-github-robot pushed a commit that referenced this issue Jan 4, 2018
Merge pull request #56971 from derekwaynecarr/limit-range-ignore-term…
cb6b88f 
…inating-pods

Automatic merge from submit-queue (batch tested with PRs 56971, 57570, 57830, 57742). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

LimitRange ignores objects previously marked for deletion

**What this PR does / why we need it**:
A `LimitRange` added to a namespace after it has pods can prevent terminating pods from being deleted if they do not conform to the min/max criteria.

xref https://bugzilla.redhat.com/show_bug.cgi?id=1509309

Fixes #57201

```release-note
NONE
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@derekwaynecarr @k8s-github-robot @k8s-ci-robot @jennybuckley