controller-manager: switch to options+config pattern and add https+auth #59582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/XXL
k8s-ci-robot
requested review from
caesarxuchao,
dchen1107,
deads2k,
derekwaynecarr,
enisoc,
foxish,
hongchaodeng,
jayunit100,
lavalamp,
luxas,
madhusudancs,
MrHohn,
nikhiljindal and
wlan0
k8s-ci-robot
added
the
cncf-cla: yes
sttts
force-pushed
the
sttts-ctrl-mgr-auth
branch
from
e3eedc2
to
ebbb47e
Compare
|
/cc @stewart-yu |
|
@sttts: GitHub didn't allow me to request PR reviews from the following users: stewart-yu. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
sttts
removed request for
madhusudancs,
lavalamp,
jayunit100,
foxish,
hongchaodeng,
wlan0,
caesarxuchao,
luxas and
derekwaynecarr
sttts
force-pushed
the
sttts-ctrl-mgr-auth
branch
from
6de5546
to
5483ab7
Compare
k8s-github-robot
removed
the
needs-rebase
sttts
added
the
needs-rebase
k8s-github-robot
removed
lgtm
sttts
added
the
lgtm
|
/assign @luxas For approval of the cloud-cfg-mgr changes. |
|
/assign @mikedanese For approval. Also compare #59814 to avoid this in the future for the owner-less generic controller-manager code (which should not stay in cmd/ for long, but that's another story). |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, mikedanese, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these OWNERS Files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Automatic merge from submit-queue (batch tested with PRs 59653, 58812, 59582, 59665, 59511). If you want to cherry-pick this change to another branch, please follow the instructions here. |
mikedanese
added a commit
to mikedanese/kubernetes
that referenced
this pull request
Feb 15, 2018
introduced in kubernetes#59582
k8s-github-robot
pushed a commit
that referenced
this pull request
Feb 15, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. apiserver: fix some typos from refactor introduced in #59582 ```release-note NONE ```
jingxu97
pushed a commit
to jingxu97/kubernetes
that referenced
this pull request
Mar 13, 2018
introduced in kubernetes#59582
k8s-github-robot
pushed a commit
that referenced
this pull request
Apr 10, 2018
…-chain Automatic merge from submit-queue (batch tested with PRs 60197, 61614, 62074, 62071, 62301). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Refactor controller-manager: turn Serve func into handlerchain builder **What this PR does / why we need it**: follow up #59582 fix > turn Serve func into a handler chain builder #59582 (comment) **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
k8s-github-robot
pushed a commit
that referenced
this pull request
Apr 13, 2018
Automatic merge from submit-queue (batch tested with PRs 61306, 60270, 62496, 62181, 62234). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. split up the huge set of flags into smaller option structs **What this PR does / why we need it**: To make generic, we do following work: 1. Spliting `KubeControllerManagerConfiguration` in kube-controller-manager and cloud-controller-manager into fewer smaller struct options order by controller, and modify relative flag. Also part of #59483. 2. Spliting `componentconfig` in controller-manager into fewer smaller config order by controller too. All works follow #59582, using `option+config` logic. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switch the {kube,cloud}-controller-managers to use the Options+Config struct pattern for bootstrapping, as we use it throughout all apiservers. This allows us to easily plug in https and authn/z support.
Fixes parts of #59483
This is equivalent to #59408 after squashing.