Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump etcd to 3.3 #61326

Closed
tylerauerbeck opened this issue Mar 18, 2018 · 22 comments · Fixed by #71615
Closed

Bump etcd to 3.3 #61326

tylerauerbeck opened this issue Mar 18, 2018 · 22 comments · Fixed by #71615
Assignees
Labels
area/kubeadm lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability.
Milestone

Comments

@tylerauerbeck
Copy link

Is this a BUG REPORT or FEATURE REQUEST?:
/kind feature

What happened:
It looks like there are a handful of issues waiting on a bump of etcd to v3.3. Is there any timeline on pushing this? Is there any work already being done on this?

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Mar 18, 2018
@tylerauerbeck
Copy link
Author

Not sure what would be most appropriate for this, so I'll start with the sigs from the issues that are already open: #48297 #45037 #46705

/sig instrumentation
/sig api-machinery
/sig scalability

If anybody has suggestions on something more appropriate, please let me know.

@k8s-ci-robot k8s-ci-robot added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 19, 2018
@jennybuckley
Copy link

/cc @jpbetz @wenjiaswe

@jpbetz
Copy link
Contributor

jpbetz commented Mar 20, 2018

Yes and Yes. But are you asking about the etcd server or client? Kubernetes 1.10 (slated for release tomorrow) will use the etcd 3.2 client and default to etcd 3.1 for the server (although kubernetes cluster operators can run any etcd server version they want).

Kubernetes 1.11 will be upgraded to use the etcd 3.3 client (#58551 already validated this upgrade is safe and will be cloned shortly to make the actual upgrade on master). It is likely the the default etcd server version for 1.11 will be etcd 3.2 since for downgrade reasons we can only upgrade by one minor etcd version per k8s minor version. But again, cluster operators can run whatever version they want.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 18, 2018
@jpbetz
Copy link
Contributor

jpbetz commented Jun 18, 2018

/remove-lifecycle stale

We'll do this bump once 1.12 opens for PRs.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 18, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 16, 2018
@nikhita
Copy link
Member

nikhita commented Sep 18, 2018

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 18, 2018
@jpbetz
Copy link
Contributor

jpbetz commented Sep 18, 2018

Update: etcd 3.3 bump is now slated for Kubernetes 1.13.

@jpbetz
Copy link
Contributor

jpbetz commented Oct 2, 2018

PR to upgrade etcd client to 3.3: #69322

@lavalamp lavalamp added this to the v1.14 milestone Nov 15, 2018
@lavalamp
Copy link
Member

I set the milestone to 1.14; let's try to get this out as soon as master reopens so we have lots of soak time.

@timothysc
Copy link
Member

/assign @jpbetz @wojtek-t @timothysc
/sig scalability
/sig cluster-lifecycle
/area kubeadm

/cc @kubernetes/sig-cluster-lifecycle

@lavalamp
Copy link
Member

/assign @jpbetz @timothysc @wojtek-t

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Nov 15, 2018
@timothysc
Copy link
Member

/cc @gyuho

@timothysc timothysc added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Nov 15, 2018
@luxas
Copy link
Member

luxas commented Nov 16, 2018

Just to clarify here -- etcd 3.3.x client is shipped in v1.13, and etcd 3.3.x server is targeted for v1.14?

@gyuho
Copy link
Member

gyuho commented Nov 16, 2018

@luxas Yes, etcd v3.3 client was merged here #69322, but etcd server bump-up to v1.13 never happened (hence targted for v1.14).

@jpbetz
Copy link
Contributor

jpbetz commented Nov 26, 2018

Sorry for the belated response on this. Yes v1.14 is best for etcd server 3.3 bump. We don't require the etcd client and server be bumped together, and given the large volume of transitive vendoring changes pulled in by the etcd 3.3 client we went with a full Kubenetes release cycle to bake the client bump in isolation from server changes.

@timothysc
Copy link
Member

@jpbetz @ixdy - Now that 1.14 is open could a googler please push an updated image.

/cc @kubernetes/sig-release

@jpbetz
Copy link
Contributor

jpbetz commented Nov 30, 2018

@timothysc Starting build/push of 3.3.10 image now

@jpbetz
Copy link
Contributor

jpbetz commented Nov 30, 2018

Build and staging push complete. We've requested promotion of the staging images to k8s.gcr.io. Client upgrade PR is #71615.

@luxas
Copy link
Member

luxas commented Dec 4, 2018

Shall we reopen this to track the scalability implications or will you create a different issue to track that @jpbetz @gyuho?

@gyuho
Copy link
Member

gyuho commented Dec 4, 2018

@luxas Was there any scalability issue related to etcd 3.3 upgrade?

@luxas
Copy link
Member

luxas commented Dec 4, 2018

@gyuho I don't know, but we should track and investigate if there is 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubeadm lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability.
Projects
None yet
Development

Successfully merging a pull request may close this issue.