Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stub everything #1

Merged
merged 2 commits into from
Jan 31, 2019
Merged

stub everything #1

merged 2 commits into from
Jan 31, 2019

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jan 31, 2019

This produces a command and some rough resources that probably won't work, but gets the repo started.

/assign @hexfusion

version: ee1a9a0726d2ae45f54118cac878c990d4016ded
- name: github.com/coreos/etcd
version: 420a452267a7ce45b3fcbed04d54030d69964fc1
subpackages:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this is etcd 3.2.24 openshift 4.0 is using 3.3.x. (3.3.10) Now k8s 1.11 brought in the v3.3.x etcd client I am just wondering if we should bump this as well?

kubernetes/kubernetes#61326 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well no that didn't make it until 1.13 kubernetes/kubernetes#69322 nmd.

@deads2k
Copy link
Contributor Author

deads2k commented Jan 31, 2019

I'm going to merge this so that we can start the CI process. Feel free to continue making comments and we can take time tomorrow to explain what it does

@deads2k deads2k merged commit 472095a into openshift:master Jan 31, 2019
ports:
- name: https
port: 443
targetPort: 10257
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2379, I guess we need a peer in here is well 2380

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the targetPort meaningful

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for etcd I would not map the port, but just use the normal 2379 and 2380 one-to-one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah ack

scheme: HTTPS
port: 10257
path: healthz
initialDelaySeconds: 45
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/health

from:
kind: DockerImage
name: docker.io/openshift/origin-cluster-etcd-operator:v4.0
- name: hyperkube
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do we get this namespace in docker.io?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tnozicka can get you into the image building pipeline. He is probably already on it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR we are working on this. openshift/release#2758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants